Sign upLogin

propelorm/Propel2

View on GitHub
Star

Showing 740 of 740 total issues

Function convert has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    public static function convert(array $c): string
    {
        $conf = [];
        // set datasources
        if (isset($c['connections'])) {
Severity: Minor
Found in src/Propel/Generator/Config/ArrayToPhpConverter.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function appendTableNode has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    private function appendTableNode(Table $table, DOMNode $parentNode): void
    {
        /** @var \DOMElement $tableNode */
        $tableNode = $parentNode->appendChild($this->document->createElement('table'));
        $tableNode->setAttribute('name', $table->getCommonName());
Severity: Minor
Found in src/Propel/Generator/Schema/Dumper/XmlDumper.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method addDoSave has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function addDoSave(string &$script): void
    {
        $table = $this->getTable();

        $reloadOnUpdate = $table->isReloadOnUpdate();
Severity: Major
Found in src/Propel/Generator/Builder/Om/ObjectBuilder.php - About 4 hrs to fix

    MigrationManager has 34 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class MigrationManager extends AbstractManager
{
    use PathTrait;

    /**
    Severity: Minor
    Found in src/Propel/Generator/Manager/MigrationManager.php - About 4 hrs to fix

      File PropelConfiguration.php has 346 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

/**
 * MIT License. This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
      Severity: Minor
      Found in src/Propel/Common/Config/PropelConfiguration.php - About 4 hrs to fix

        File SchemaReader.php has 344 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php

/**
 * MIT License. This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
        Severity: Minor
        Found in src/Propel/Generator/Builder/Util/SchemaReader.php - About 4 hrs to fix

          Function normalizeTable has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
          Open

              public function normalizeTable(Table $table): void
    {
        if ($table->getPrimaryKey()) {
            //search if there is already a UNIQUE constraint over the primary keys
            $pkUniqueExist = false;
          Severity: Minor
          Found in src/Propel/Generator/Platform/SqlitePlatform.php - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method execute has 105 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $configOptions = [];

        if ($this->hasInputOption('output-dir', $input)) {
          Severity: Major
          Found in src/Propel/Generator/Command/MigrationStatusCommand.php - About 4 hrs to fix

            StandardServiceContainer has 33 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class StandardServiceContainer implements ServiceContainerInterface
{
    /**
     * Expected version of the configuration file.
     *
            Severity: Minor
            Found in src/Propel/Runtime/ServiceContainer/StandardServiceContainer.php - About 4 hrs to fix

              Method addDatabaseSection has 104 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function addDatabaseSection(ArrayNodeDefinition $node): void
    {
        $node
            ->children()
                ->arrayNode('database')
              Severity: Major
              Found in src/Propel/Common/Config/PropelConfiguration.php - About 4 hrs to fix

                Method appendTableNode has 102 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function appendTableNode(Table $table, DOMNode $parentNode): void
    {
        /** @var \DOMElement $tableNode */
        $tableNode = $parentNode->appendChild($this->document->createElement('table'));
        $tableNode->setAttribute('name', $table->getCommonName());
                Severity: Major
                Found in src/Propel/Generator/Schema/Dumper/XmlDumper.php - About 4 hrs to fix

                  Behavior has 32 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Behavior extends MappingModel
{
    use PathTrait;

    /**
                  Severity: Minor
                  Found in src/Propel/Generator/Model/Behavior.php - About 4 hrs to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                } else {
                if ($col->isForeignKey()) {
                    foreach ($col->getForeignKeys() as $fk) {
                        $script .= "
        \$this->addForeignKey('$columnName', '$cfc', '" . $col->getType() . "', '" . $fk->getForeignTableName() . "', '" . $fk->getMappedForeignColumn($col->getName()) . "', " . ($col->isNotNull() ? 'true' : 'false') . ', ' . $size . ", $default);";
                    Severity: Major
                    Found in src/Propel/Generator/Builder/Om/TableMapBuilder.php and 1 other location - About 4 hrs to fix
                    src/Propel/Generator/Builder/Om/TableMapBuilder.php on lines 574..594

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 162.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if ($col->isPrimaryKey()) {
                if ($col->isForeignKey()) {
                    foreach ($col->getForeignKeys() as $fk) {
                        $script .= "
        \$this->addForeignPrimaryKey('$columnName', '$cfc', '" . $col->getType() . "' , '" . $fk->getForeignTableName() . "', '" . $fk->getMappedForeignColumn($col->getName()) . "', " . ($col->isNotNull() ? 'true' : 'false') . ', ' . $size . ", $default);";
                    Severity: Major
                    Found in src/Propel/Generator/Builder/Om/TableMapBuilder.php and 1 other location - About 4 hrs to fix
                    src/Propel/Generator/Builder/Om/TableMapBuilder.php on lines 584..594

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 162.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function hydratePropelObjectCollection has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function &hydratePropelObjectCollection(array $row): array
    {
        $col = 0;

        // hydrate main object or take it from registry
                    Severity: Minor
                    Found in src/Propel/Runtime/Formatter/AbstractFormatterWithHydration.php - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    DataModelBuilder has 31 functions (exceeds 20 allowed). Consider refactoring.
                    Open

                    abstract class DataModelBuilder
{
    /**
     * The current table.
     *
                    Severity: Minor
                    Found in src/Propel/Generator/Builder/DataModelBuilder.php - About 3 hrs to fix

                      SqlitePlatform has 31 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      class SqlitePlatform extends DefaultPlatform
{
    /**
     * If we should generate FOREIGN KEY statements.
     * This is since SQLite version 3.6.19 possible.
                      Severity: Minor
                      Found in src/Propel/Generator/Platform/SqlitePlatform.php - About 3 hrs to fix

                        SortableBehaviorObjectBuilderModifier has 31 functions (exceeds 20 allowed). Consider refactoring.
                        Open

                        class SortableBehaviorObjectBuilderModifier
{
    /**
     * @var \Propel\Generator\Behavior\Sortable\SortableBehavior
     */
                        Severity: Minor
                        Found in src/Propel/Generator/Behavior/Sortable/SortableBehaviorObjectBuilderModifier.php - About 3 hrs to fix

                          Method addForeignKeys has 95 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              protected function addForeignKeys(Table $table, int $oid): void
    {
        $database = $table->getDatabase();
        $stmt = $this->dbh->prepare("SELECT
            conname,
                          Severity: Major
                          Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 3 hrs to fix

                            Function execute has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                            Open

                                protected function execute(InputInterface $input, OutputInterface $output): int
    {
        $configOptions = [];
        $inputOptions = $input->getOptions();
                            Severity: Minor
                            Found in src/Propel/Generator/Command/ModelBuildCommand.php - About 3 hrs to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language