propelorm/Propel2

View on GitHub
src/Propel/Common/Config/XmlToArrayConverter.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function simpleXmlToArray has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    protected static function simpleXmlToArray(SimpleXMLElement $xml): array
    {
        $ar = [];
        foreach ($xml->children() as $k => $v) {
            // recurse the child
Severity: Minor
Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method simpleXmlToArray has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected static function simpleXmlToArray(SimpleXMLElement $xml): array
    {
        $ar = [];
        foreach ($xml->children() as $k => $v) {
            // recurse the child
Severity: Minor
Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 1 hr to fix

    Method convert has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function convert(string $xmlToParse): array
        {
            $isFile = file_exists($xmlToParse);
    
            if ($isFile) {
    Severity: Minor
    Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 1 hr to fix

      Function convert has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function convert(string $xmlToParse): array
          {
              $isFile = file_exists($xmlToParse);
      
              if ($isFile) {
      Severity: Minor
      Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return $value;
      Severity: Major
      Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status