propelorm/Propel2

View on GitHub
src/Propel/Common/Config/XmlToArrayConverter.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function simpleXmlToArray has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected static function simpleXmlToArray($xml)
    {
        $ar = [];
        foreach ($xml->children() as $k => $v) {
            // recurse the child
Severity: Minor
Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method convert has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function convert($xmlToParse)
    {
        if (!is_string($xmlToParse)) {
            throw new InvalidArgumentException("XmlToArrayConverter::convert method expects an xml file to parse, or a string containing valid xml");
        }
Severity: Minor
Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 1 hr to fix

    Function convert has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function convert($xmlToParse)
        {
            if (!is_string($xmlToParse)) {
                throw new InvalidArgumentException("XmlToArrayConverter::convert method expects an xml file to parse, or a string containing valid xml");
            }
    Severity: Minor
    Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method simpleXmlToArray has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected static function simpleXmlToArray($xml)
        {
            $ar = [];
            foreach ($xml->children() as $k => $v) {
                // recurse the child
    Severity: Minor
    Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 1 hr to fix

      Function getConvertedXmlValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function getConvertedXmlValue($value)
          {
              $value = (string) $value; // convert from simplexml to string
      
              //handle numeric values
      Severity: Minor
      Found in src/Propel/Common/Config/XmlToArrayConverter.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status