propelorm/Propel2

View on GitHub
src/Propel/Generator/Behavior/Sortable/SortableBehaviorObjectBuilderModifier.php

Summary

Maintainability
D
3 days
Test Coverage

File SortableBehaviorObjectBuilderModifier.php has 512 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * MIT License. This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE

    SortableBehaviorObjectBuilderModifier has 31 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class SortableBehaviorObjectBuilderModifier
    {
        /**
         * @var \Propel\Generator\Behavior\Sortable\SortableBehavior
         */

      Method addScopeAccessors has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function addScopeAccessors(string &$script): void
          {
              $script .= "
      /**
       * Wrap the getter for scope value

        Function addScopeAccessors has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function addScopeAccessors(string &$script): void
            {
                $script .= "
        /**
         * Wrap the getter for scope value

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method objectMethods has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function objectMethods(AbstractOMBuilder $builder): string
            {
                $this->setBuilder($builder);
                $script = '';
                if ($this->getParameter('rank_column') !== 'rank') {

          Method addSwapWith has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function addSwapWith(string &$script): void
              {
                  $script .= "
          /**
           * Exchange the rank of the object with the one passed as argument, and saves both objects

            Method addMoveToRank has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function addMoveToRank(string &$script): void
                {
                    $useScope = $this->behavior->useScope();
                    $script .= "
            /**

              Function objectFilter has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function objectFilter(string &$script, AbstractOMBuilder $builder): void
                  {
                      if ($this->behavior->useScope()) {
                          if ($this->behavior->hasMultipleScopes()) {
                              foreach ($this->behavior->getScopes() as $idx => $scope) {

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  protected function addGetNext(string &$script): void
                  {
                      $useScope = $this->behavior->useScope();
                      // The generateScopePhp() method below contains the following list of variables:
                      // list($methodSignature, $paramsDoc, $buildScope, $buildScopeVars)
              src/Propel/Generator/Behavior/Sortable/SortableBehaviorObjectBuilderModifier.php on lines 524..566

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 132.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  protected function addGetPrevious(string &$script): void
                  {
                      $useScope = $this->behavior->useScope();
              
                      // The generateScopePhp() method below contains the following list of variables:
              src/Propel/Generator/Behavior/Sortable/SortableBehaviorObjectBuilderModifier.php on lines 476..517

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 132.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status