propelorm/Propel2

View on GitHub
src/Propel/Generator/Model/Diff/DatabaseComparator.php

Summary

Maintainability
C
1 day
Test Coverage

Function compareTables has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

    public function compareTables($caseInsensitive = false)
    {
        $fromDatabaseTables = $this->fromDatabase->getTables();
        $toDatabaseTables = $this->toDatabase->getTables();
        $databaseDifferences = 0;
Severity: Minor
Found in src/Propel/Generator/Model/Diff/DatabaseComparator.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compareTables has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function compareTables($caseInsensitive = false)
    {
        $fromDatabaseTables = $this->fromDatabase->getTables();
        $toDatabaseTables = $this->toDatabase->getTables();
        $databaseDifferences = 0;
Severity: Major
Found in src/Propel/Generator/Model/Diff/DatabaseComparator.php - About 2 hrs to fix

    Method computeDiff has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static function computeDiff(Database $fromDatabase, Database $toDatabase, $caseInsensitive = false, $withRenaming = false, $removeTable = true, $excludedTables = [])
    Severity: Minor
    Found in src/Propel/Generator/Model/Diff/DatabaseComparator.php - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status