Sign upLogin

propelorm/Propel2

View on GitHub
Star
src/Propel/Generator/Model/Diff/ForeignKeyComparator.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method computeDiff has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function computeDiff(ForeignKey $fromFk, ForeignKey $toFk, bool $caseInsensitive = false): bool
    {
        // Check for differences in local and remote table
        $fromDifferentTable = $caseInsensitive ?
            strtolower($fromFk->getTableName()) !== strtolower($toFk->getTableName()) :
Severity: Minor
Found in src/Propel/Generator/Model/Diff/ForeignKeyComparator.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return true;
    Severity: Major
    Found in src/Propel/Generator/Model/Diff/ForeignKeyComparator.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return $fromFk->isSkipSql() !== $toFk->isSkipSql();
      Severity: Major
      Found in src/Propel/Generator/Model/Diff/ForeignKeyComparator.php - About 30 mins to fix

        Function computeDiff has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function computeDiff(ForeignKey $fromFk, ForeignKey $toFk, bool $caseInsensitive = false): bool
    {
        // Check for differences in local and remote table
        $fromDifferentTable = $caseInsensitive ?
            strtolower($fromFk->getTableName()) !== strtolower($toFk->getTableName()) :
        Severity: Minor
        Found in src/Propel/Generator/Model/Diff/ForeignKeyComparator.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status