propelorm/Propel2

View on GitHub
src/Propel/Generator/Model/Table.php

Summary

Maintainability
F
1 wk
Test Coverage

File Table.php has 1036 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
Severity: Major
Found in src/Propel/Generator/Model/Table.php - About 2 days to fix

    Table has 119 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Table extends ScopedMappingModel implements IdMethod
    {
        use BehaviorableTrait;
    
        /**
    Severity: Major
    Found in src/Propel/Generator/Model/Table.php - About 2 days to fix

      Function isUnique has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
      Open

          public function isUnique(array $keys)
          {
              if (1 === count($keys)) {
                  $column = $keys[0] instanceof Column ? $keys[0] : $this->getColumn($keys[0]);
                  if ($column) {
      Severity: Minor
      Found in src/Propel/Generator/Model/Table.php - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function setupReferrers has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
      Open

          public function setupReferrers($throwErrors = false)
          {
              foreach ($this->foreignKeys as $foreignKey) {
      
                  // table referrers
      Severity: Minor
      Found in src/Propel/Generator/Model/Table.php - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function isIndex has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

          public function isIndex(array $keys)
          {
              if ($this->indices) {
                  foreach ($this->indices as $index) {
                      if (count($keys) === count($index->getColumns())) {
      Severity: Minor
      Found in src/Propel/Generator/Model/Table.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method setupReferrers has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function setupReferrers($throwErrors = false)
          {
              foreach ($this->foreignKeys as $foreignKey) {
      
                  // table referrers
      Severity: Major
      Found in src/Propel/Generator/Model/Table.php - About 2 hrs to fix

        Method isUnique has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function isUnique(array $keys)
            {
                if (1 === count($keys)) {
                    $column = $keys[0] instanceof Column ? $keys[0] : $this->getColumn($keys[0]);
                    if ($column) {
        Severity: Minor
        Found in src/Propel/Generator/Model/Table.php - About 2 hrs to fix

          Function addExtraIndices has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function addExtraIndices()
              {
                  /**
                   * A collection of indexed columns. The keys is the column name
                   * (concatenated with a comma in the case of multi-col index), the value is
          Severity: Minor
          Found in src/Propel/Generator/Model/Table.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getCrossFks has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getCrossFks()
              {
                  $crossFks = [];
                  foreach ($this->referrers as $refFK) {
                      if ($refFK->getTable()->isCrossRef()) {
          Severity: Minor
          Found in src/Propel/Generator/Model/Table.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method setupObject has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function setupObject()
              {
                  parent::setupObject();
          
                  $this->commonName = $this->originCommonName = $this->getAttribute('name');
          Severity: Minor
          Found in src/Propel/Generator/Model/Table.php - About 1 hr to fix

            Method addExtraIndices has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function addExtraIndices()
                {
                    /**
                     * A collection of indexed columns. The keys is the column name
                     * (concatenated with a comma in the case of multi-col index), the value is
            Severity: Minor
            Found in src/Propel/Generator/Model/Table.php - About 1 hr to fix

              Method __construct has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function __construct($name = null)
                  {
                      parent::__construct();
              
                      if (null !== $name) {
              Severity: Minor
              Found in src/Propel/Generator/Model/Table.php - About 1 hr to fix

                Function addColumn has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function addColumn($col)
                    {
                        if ($col instanceof Column) {
                
                            if (isset($this->columnsByName[$col->getName()])) {
                Severity: Minor
                Found in src/Propel/Generator/Model/Table.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                        return false;
                Severity: Major
                Found in src/Propel/Generator/Model/Table.php - About 30 mins to fix

                  Function getAutoIncrementPrimaryKey has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getAutoIncrementPrimaryKey()
                      {
                          if (IdMethod::NO_ID_METHOD !== $this->getIdMethod()) {
                              foreach ($this->getPrimaryKey() as $pk) {
                                  if ($pk->isAutoIncrement()) {
                  Severity: Minor
                  Found in src/Propel/Generator/Model/Table.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function addIndex has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function addIndex($index)
                      {
                          if ($index instanceof Index) {
                              if ($this->hasIndex($index->getName())) {
                                  throw new InvalidArgumentException(sprintf('Index "%s" already exist.', $index->getName()));
                  Severity: Minor
                  Found in src/Propel/Generator/Model/Table.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function doFinalInitialization has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function doFinalInitialization()
                      {
                          // Heavy indexing must wait until after all columns composing
                          // a table's primary key have been parsed.
                          if ($this->heavyIndexing) {
                  Severity: Minor
                  Found in src/Propel/Generator/Model/Table.php - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function __clone()
                      {
                          $columns = [];
                          foreach ($this->columns as $oldCol) {
                              $col = clone $oldCol;
                  Severity: Major
                  Found in src/Propel/Generator/Model/Table.php and 1 other location - About 1 hr to fix
                  src/Propel/Generator/Model/Database.php on lines 954..965

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 87.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function setDefaultStringFormat($format)
                      {
                          $formats = Database::getSupportedStringFormats();
                  
                          $format = strtoupper($format);
                  Severity: Minor
                  Found in src/Propel/Generator/Model/Table.php and 1 other location - About 55 mins to fix
                  src/Propel/Generator/Model/Database.php on lines 312..322

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 82.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status