propelorm/Propel2

View on GitHub
src/Propel/Generator/Platform/MysqlPlatform.php

Summary

Maintainability
F
4 days
Test Coverage

File MysqlPlatform.php has 564 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
Severity: Major
Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 1 day to fix

    MysqlPlatform has 45 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class MysqlPlatform extends DefaultPlatform
    {
        protected $tableEngineKeyword = 'ENGINE';  // overwritten in propel config
        protected $defaultTableEngine = 'InnoDB';  // overwritten in propel config
    
    
    Severity: Minor
    Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 6 hrs to fix

      Function getColumnDDL has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getColumnDDL(Column $col)
          {
              $domain = $col->getDomain();
              $sqlType = $domain->getSqlType();
              $notNullString = $this->getNullString($col->isNotNull());
      Severity: Minor
      Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getColumnDDL has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getColumnDDL(Column $col)
          {
              $domain = $col->getDomain();
              $sqlType = $domain->getSqlType();
              $notNullString = $this->getNullString($col->isNotNull());
      Severity: Major
      Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 2 hrs to fix

        Function getAddTableDDL has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getAddTableDDL(Table $table)
            {
                $lines = [];
        
                foreach ($table->getColumns() as $column) {
        Severity: Minor
        Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getAddTableDDL has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getAddTableDDL(Table $table)
            {
                $lines = [];
        
                foreach ($table->getColumns() as $column) {
        Severity: Major
        Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 2 hrs to fix

          Method getTableOptions has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function getTableOptions(Table $table)
              {
                  $dbVI = $table->getDatabase()->getVendorInfoForType('mysql');
                  $tableVI = $table->getVendorInfoForType('mysql');
                  $vi = $dbVI->getMergedVendorInfo($tableVI);
          Severity: Minor
          Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 1 hr to fix

            Function getTableOptions has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function getTableOptions(Table $table)
                {
                    $dbVI = $table->getDatabase()->getVendorInfoForType('mysql');
                    $tableVI = $table->getVendorInfoForType('mysql');
                    $vi = $dbVI->getMergedVendorInfo($tableVI);
            Severity: Minor
            Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getPrimaryKeyDDL has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getPrimaryKeyDDL(Table $table)
                {
                    if ($table->hasPrimaryKey()) {
            
                        $keys = $table->getPrimaryKey();
            Severity: Minor
            Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getAddColumnDDL has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getAddColumnDDL(Column $column)
                {
                    $pattern = "
            ALTER TABLE %s ADD %s %s;
            ";
            Severity: Minor
            Found in src/Propel/Generator/Platform/MysqlPlatform.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $supportedOptions = [
                        'AutoIncrement'   => 'AUTO_INCREMENT',
                        'AvgRowLength'    => 'AVG_ROW_LENGTH',
                        'Charset'         => 'CHARACTER SET',
                        'Checksum'        => 'CHECKSUM',
            Severity: Major
            Found in src/Propel/Generator/Platform/MysqlPlatform.php and 1 other location - About 1 hr to fix
            src/Propel/Common/Pluralizer/StandardEnglishPluralizer.php on lines 78..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 92.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status