Sign upLogin

propelorm/Propel2

View on GitHub
Star
src/Propel/Generator/Platform/PgsqlPlatform.php

Summary

Maintainability
F
4 days
Test Coverage

File PgsqlPlatform.php has 585 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * MIT License. This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
Severity: Major
Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 1 day to fix

    PgsqlPlatform has 42 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class PgsqlPlatform extends DefaultPlatform
{
    /**
     * @var string
     */
    Severity: Minor
    Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 5 hrs to fix

      Function getModifyColumnDDL has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getModifyColumnDDL(ColumnDiff $columnDiff): string
    {
        $ret = '';
        $changedProperties = $columnDiff->getChangedProperties();
      Severity: Minor
      Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getModifyColumnDDL has 78 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function getModifyColumnDDL(ColumnDiff $columnDiff): string
    {
        $ret = '';
        $changedProperties = $columnDiff->getChangedProperties();
      Severity: Major
      Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 3 hrs to fix

        Function getColumnDDL has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getColumnDDL(Column $col): string
    {
        $domain = $col->getDomain();

        $ddl = [$this->quoteIdentifier($col->getName())];
        Severity: Minor
        Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getColumnDDL has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getColumnDDL(Column $col): string
    {
        $domain = $col->getDomain();

        $ddl = [$this->quoteIdentifier($col->getName())];
        Severity: Minor
        Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 1 hr to fix

          Method getAddTableDDL has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getAddTableDDL(Table $table): string
    {
        $ret = $this->getUseSchemaDDL($table);
        $ret .= $this->getAddSequenceDDL($table);
          Severity: Minor
          Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 1 hr to fix

            Function getSequenceName has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getSequenceName(Table $table): string
    {
        $result = null;
        if ($table->getIdMethod() == IdMethod::NATIVE) {
            $idMethodParams = $table->getIdMethodParameters();
            Severity: Minor
            Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Consider simplifying this complex logical expression.
            Open

                    if (
            ($this->isNumber($fromSqlType) && $this->isNumber($toSqlType)) ||
            ($this->isString($fromSqlType) && $this->isString($toSqlType)) ||
            ($this->isNumber($fromSqlType) && $this->isString($toSqlType)) ||
            ($this->isUuid($fromSqlType) && $this->isString($toSqlType))
            Severity: Critical
            Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 1 hr to fix

              Function getUsingCast has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getUsingCast(Column $fromColumn, Column $toColumn): string
    {
        $fromSqlType = strtoupper($fromColumn->getDomain()->getSqlType());
        $toSqlType = strtoupper($toColumn->getDomain()->getSqlType());
        $name = $fromColumn->getName();
              Severity: Minor
              Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getIdentifierPhp has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      string $columnValueMutator,
        string $connectionVariableName = '$con',
        string $sequenceName = '',
        string $tab = '            ',
        ?string $phpType = null
              Severity: Minor
              Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 35 mins to fix

                Avoid too many return statements within this method.
                Open

                        return ' USING NULL';
                Severity: Major
                Found in src/Propel/Generator/Platform/PgsqlPlatform.php - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public function getIdentifierPhp(
        string $columnValueMutator,
        string $connectionVariableName = '$con',
        string $sequenceName = '',
        string $tab = '            ',
                  Severity: Major
                  Found in src/Propel/Generator/Platform/PgsqlPlatform.php and 1 other location - About 1 hr to fix
                  src/Propel/Generator/Platform/OraclePlatform.php on lines 481..503

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 117.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status