propelorm/Propel2

View on GitHub
src/Propel/Generator/Reverse/PgsqlSchemaParser.php

Summary

Maintainability
F
4 days
Test Coverage

File PgsqlSchemaParser.php has 439 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
Severity: Minor
Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 6 hrs to fix

    Function addColumns has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function addColumns(Table $table, $oid)
        {
            // Get the columns, types, etc.
            // Based on code from pgAdmin3 (http://www.pgadmin.org/)
    
    
    Severity: Minor
    Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method addForeignKeys has 92 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function addForeignKeys(Table $table, $oid)
        {
            $database = $table->getDatabase();
            $stmt = $this->dbh->prepare("SELECT
                conname,
    Severity: Major
    Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 3 hrs to fix

      Method addColumns has 87 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function addColumns(Table $table, $oid)
          {
              // Get the columns, types, etc.
              // Based on code from pgAdmin3 (http://www.pgadmin.org/)
      
      
      Severity: Major
      Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 3 hrs to fix

        Function addForeignKeys has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function addForeignKeys(Table $table, $oid)
            {
                $database = $table->getDatabase();
                $stmt = $this->dbh->prepare("SELECT
                    conname,
        Severity: Minor
        Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function parseTables has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function parseTables(&$tableWraps, Database $database, Table $filterTable = null)
            {
                $stmt = null;
        
                $params = [];
        Severity: Minor
        Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method parseTables has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function parseTables(&$tableWraps, Database $database, Table $filterTable = null)
            {
                $stmt = null;
        
                $params = [];
        Severity: Major
        Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 2 hrs to fix

          Method addIndexes has 45 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function addIndexes(Table $table, $oid)
              {
                  $stmt = $this->dbh->prepare("SELECT
                      DISTINCT ON(cls.relname)
                      cls.relname as idxname,
          Severity: Minor
          Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 1 hr to fix

            Function addIndexes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function addIndexes(Table $table, $oid)
                {
                    $stmt = $this->dbh->prepare("SELECT
                        DISTINCT ON(cls.relname)
                        cls.relname as idxname,
            Severity: Minor
            Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method addPrimaryKey has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function addPrimaryKey(Table $table, $oid)
                {
            
                    $stmt = $this->dbh->prepare("SELECT
                        DISTINCT ON(cls.relname)
            Severity: Minor
            Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 1 hr to fix

              Method addSequences has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function addSequences(Database $database)
                  {
                      $searchPath = '?';
                      $params = [$database->getSchema()];
                      if (!$database->getSchema()) {
              Severity: Minor
              Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 1 hr to fix

                Function addPrimaryKey has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function addPrimaryKey(Table $table, $oid)
                    {
                
                        $stmt = $this->dbh->prepare("SELECT
                            DISTINCT ON(cls.relname)
                Severity: Minor
                Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            switch ($row['confupdtype']) {
                                case 'c':
                                    $onupdate = ForeignKey::CASCADE;
                                    break;
                                case 'd':
                Severity: Minor
                Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php and 1 other location - About 30 mins to fix
                src/Propel/Generator/Reverse/PgsqlSchemaParser.php on lines 389..407

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 75.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            switch ($row['confdeltype']) {
                                case 'c':
                                    $ondelete = ForeignKey::CASCADE;
                                    break;
                                case 'd':
                Severity: Minor
                Found in src/Propel/Generator/Reverse/PgsqlSchemaParser.php and 1 other location - About 30 mins to fix
                src/Propel/Generator/Reverse/PgsqlSchemaParser.php on lines 369..387

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 75.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status