propelorm/Propel2

View on GitHub
src/Propel/Runtime/ActiveQuery/Criteria.php

Summary

Maintainability
F
2 wks
Test Coverage

File Criteria.php has 1374 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * This file is part of the Propel package.
 * For the full copyright and license information, please view the LICENSE
Severity: Major
Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 3 days to fix

    Criteria has 108 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Criteria
    {
    
        /** Comparison type. */
        const EQUAL = '=';
    Severity: Major
    Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 days to fix

      Function createSelectSql has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
      Open

          public function createSelectSql(&$params)
          {
              $adapter = Propel::getServiceContainer()->getAdapter($this->getDbName());
              $dbMap = Propel::getServiceContainer()->getDatabaseMap($this->getDbName());
      
      
      Severity: Minor
      Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function doUpdate has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
      Open

          public function doUpdate($updateValues, ConnectionInterface $con)
          {
              /** @var PdoAdapter $db */
              $db = Propel::getServiceContainer()->getAdapter($this->getDbName());
              $dbMap = Propel::getServiceContainer()->getDatabaseMap($this->getDbName());
      Severity: Minor
      Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method createSelectSql has 144 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function createSelectSql(&$params)
          {
              $adapter = Propel::getServiceContainer()->getAdapter($this->getDbName());
              $dbMap = Propel::getServiceContainer()->getDatabaseMap($this->getDbName());
      
      
      Severity: Major
      Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 5 hrs to fix

        Function equals has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
        Open

            public function equals($crit)
            {
                if (null === $crit || !($crit instanceof Criteria)) {
                    return false;
                }
        Severity: Minor
        Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 4 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method doUpdate has 88 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function doUpdate($updateValues, ConnectionInterface $con)
            {
                /** @var PdoAdapter $db */
                $db = Propel::getServiceContainer()->getAdapter($this->getDbName());
                $dbMap = Propel::getServiceContainer()->getDatabaseMap($this->getDbName());
        Severity: Major
        Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 3 hrs to fix

          Method doInsert has 60 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function doInsert(ConnectionInterface $con = null)
              {
                  // The primary key
                  $id = null;
                  if (null === $con) {
          Severity: Major
          Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 hrs to fix

            Consider simplifying this complex logical expression.
            Open

                        if  ($this->offset            === $criteria->getOffset()
                            && $this->limit           === $criteria->getLimit()
                            && $this->ignoreCase      === $criteria->isIgnoreCase()
                            && $this->singleRecord    === $criteria->isSingleRecord()
                            && $this->dbName          === $criteria->getDbName()
            Severity: Critical
            Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 hrs to fix

              Function replaceNames has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function replaceNames(&$sql)
                  {
                      $this->replacedColumns = [];
                      $this->currentAlias = '';
                      $this->foundMatch = false;
              Severity: Minor
              Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function mergeWith has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function mergeWith(Criteria $criteria, $operator = null)
                  {
                      // merge limit
                      $limit = $criteria->getLimit();
                      if (0 != $limit && -1 === $this->getLimit()) {
              Severity: Minor
              Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method mergeWith has 52 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function mergeWith(Criteria $criteria, $operator = null)
                  {
                      // merge limit
                      $limit = $criteria->getLimit();
                      if (0 != $limit && -1 === $this->getLimit()) {
              Severity: Major
              Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 2 hrs to fix

                Function doInsert has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function doInsert(ConnectionInterface $con = null)
                    {
                        // The primary key
                        $id = null;
                        if (null === $con) {
                Severity: Minor
                Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method equals has 47 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function equals($crit)
                    {
                        if (null === $crit || !($crit instanceof Criteria)) {
                            return false;
                        }
                Severity: Minor
                Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 hr to fix

                  Method addMultipleJoin has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function addMultipleJoin($conditions, $joinType = null)
                      {
                          $join = new Join();
                          $join->setIdentifierQuoting($this->isIdentifierQuotingEnabled());
                          $joinCondition = null;
                  Severity: Minor
                  Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 hr to fix

                    Method replaceNames has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function replaceNames(&$sql)
                        {
                            $this->replacedColumns = [];
                            $this->currentAlias = '';
                            $this->foundMatch = false;
                    Severity: Minor
                    Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 hr to fix

                      Function addMultipleJoin has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function addMultipleJoin($conditions, $joinType = null)
                          {
                              $join = new Join();
                              $join->setIdentifierQuoting($this->isIdentifierQuotingEnabled());
                              $joinCondition = null;
                      Severity: Minor
                      Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method doDelete has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function doDelete(ConnectionInterface $con = null)
                          {
                              if (null === $con) {
                                  $con = Propel::getServiceContainer()->getWriteConnection($this->getDbName());
                              }
                      Severity: Minor
                      Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 hr to fix

                        Method doCount has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function doCount(ConnectionInterface $con = null)
                            {
                                $dbMap = Propel::getServiceContainer()->getDatabaseMap($this->getDbName());
                                $db = Propel::getServiceContainer()->getAdapter($this->getDbName());
                        
                        
                        Severity: Minor
                        Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 hr to fix

                          Function doCount has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function doCount(ConnectionInterface $con = null)
                              {
                                  $dbMap = Propel::getServiceContainer()->getDatabaseMap($this->getDbName());
                                  $db = Propel::getServiceContainer()->getAdapter($this->getDbName());
                          
                          
                          Severity: Minor
                          Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 1 hr to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function quoteIdentifier has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function quoteIdentifier($string, $tableName = '')
                              {
                                  if ($this->isIdentifierQuotingEnabled()) {
                                      $adapter = Propel::getServiceContainer()->getAdapter($this->getDbName());
                          
                          
                          Severity: Minor
                          Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function putAll has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function putAll($t)
                              {
                                  if (is_array($t)) {
                                      foreach ($t as $key => $value) {
                                          if ($value instanceof AbstractCriterion) {
                          Severity: Minor
                          Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function doDelete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function doDelete(ConnectionInterface $con = null)
                              {
                                  if (null === $con) {
                                      $con = Propel::getServiceContainer()->getWriteConnection($this->getDbName());
                                  }
                          Severity: Minor
                          Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 45 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function combine has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public function combine($criterions = [], $operator = self::LOGICAL_AND, $name = null)
                              {
                                  $operatorMethod = (self::LOGICAL_AND === strtoupper($operator)) ? 'addAnd' : 'addOr';
                                  $namedCriterions = [];
                                  foreach ($criterions as $key) {
                          Severity: Minor
                          Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 35 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Avoid too many return statements within this method.
                          Open

                                          return new BinaryCriterion($this, $column, $value, $comparison);
                          Severity: Major
                          Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return true;
                            Severity: Major
                            Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                      return false;
                              Severity: Major
                              Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return new BasicCriterion($this, $column, $value, $comparison);
                                Severity: Major
                                Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                      return false;
                                  Severity: Major
                                  Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                            return false;
                                    Severity: Major
                                    Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                      return false;
                                      Severity: Major
                                      Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 30 mins to fix

                                        Function needsSelectAliases has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                        Open

                                            public function needsSelectAliases()
                                            {
                                                $columnNames = [];
                                                foreach ($this->getSelectColumns() as $fullyQualifiedColumnName) {
                                                    $pos = strrpos($fullyQualifiedColumnName, '.');
                                        Severity: Minor
                                        Found in src/Propel/Runtime/ActiveQuery/Criteria.php - About 25 mins to fix

                                        Cognitive Complexity

                                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                        A method's cognitive complexity is based on a few simple rules:

                                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                        • Code is considered more complex for each "break in the linear flow of the code"
                                        • Code is considered more complex when "flow breaking structures are nested"

                                        Further reading

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                                    if ($pos) {
                                                        $rightTableAlias = substr($right, 0, $pos);
                                                        $rightColumnName = substr($right, $pos + 1);
                                                        list($rightTableName, $rightTableAlias) = $this->getTableNameAndAlias($rightTableAlias);
                                                    } else {
                                        Severity: Major
                                        Found in src/Propel/Runtime/ActiveQuery/Criteria.php and 1 other location - About 1 hr to fix
                                        src/Propel/Runtime/ActiveQuery/Criteria.php on lines 970..977

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 93.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        Similar blocks of code found in 2 locations. Consider refactoring.
                                        Open

                                                    if ($pos) {
                                                        $leftTableAlias = substr($left, 0, $pos);
                                                        $leftColumnName = substr($left, $pos + 1);
                                                        list($leftTableName, $leftTableAlias) = $this->getTableNameAndAlias($leftTableAlias);
                                                    } else {
                                        Severity: Major
                                        Found in src/Propel/Runtime/ActiveQuery/Criteria.php and 1 other location - About 1 hr to fix
                                        src/Propel/Runtime/ActiveQuery/Criteria.php on lines 980..987

                                        Duplicated Code

                                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                        Tuning

                                        This issue has a mass of 93.

                                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                        Refactorings

                                        Further Reading

                                        There are no issues that match your filters.

                                        Category
                                        Status