propelorm/Propel2

View on GitHub
src/Propel/Runtime/Map/TableMap.php

Summary

Maintainability
D
2 days
Test Coverage

TableMap has 52 functions (exceeds 20 allowed). Consider refactoring.
Open

class TableMap
{
    /**
     * phpname type
     * e.g. 'AuthorId'
Severity: Major
Found in src/Propel/Runtime/Map/TableMap.php - About 7 hrs to fix

    File TableMap.php has 394 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     * MIT License. This file is part of the Propel package.
     * For the full copyright and license information, please view the LICENSE
    Severity: Minor
    Found in src/Propel/Runtime/Map/TableMap.php - About 5 hrs to fix

      Method addColumn has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              string $name,
              string $phpName,
              string $type,
              bool $isNotNull = false,
              ?int $size = null,
      Severity: Major
      Found in src/Propel/Runtime/Map/TableMap.php - About 1 hr to fix

        Method addForeignKey has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                string $columnName,
                string $phpName,
                string $type,
                string $fkTable,
                string $fkColumn,
        Severity: Major
        Found in src/Propel/Runtime/Map/TableMap.php - About 1 hr to fix

          Method addRelation has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  string $name,
                  string $tablePhpName,
                  int $type,
                  array $joinConditionMapping = [],
                  ?string $onDelete = null,
          Severity: Major
          Found in src/Propel/Runtime/Map/TableMap.php - About 1 hr to fix

            Method addForeignPrimaryKey has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                    string $columnName,
                    string $phpName,
                    string $type,
                    string $fkTable,
                    string $fkColumn,
            Severity: Major
            Found in src/Propel/Runtime/Map/TableMap.php - About 1 hr to fix

              Method addPrimaryKey has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      string $columnName,
                      string $phpName,
                      string $type,
                      bool $isNotNull = false,
                      ?int $size = null,
              Severity: Minor
              Found in src/Propel/Runtime/Map/TableMap.php - About 45 mins to fix

                Function extractPrimaryKey has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function extractPrimaryKey(Criteria $criteria): ?array
                    {
                        $pkCols = $this->getPrimaryKeys();
                        if (count($pkCols) !== count($criteria->getMap())) {
                            return null;
                Severity: Minor
                Found in src/Propel/Runtime/Map/TableMap.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function addForeignKey(
                        string $columnName,
                        string $phpName,
                        string $type,
                        string $fkTable,
                Severity: Minor
                Found in src/Propel/Runtime/Map/TableMap.php and 1 other location - About 40 mins to fix
                src/Propel/Runtime/Map/TableMap.php on lines 700..711

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 94.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function addForeignPrimaryKey(
                        string $columnName,
                        string $phpName,
                        string $type,
                        string $fkTable,
                Severity: Minor
                Found in src/Propel/Runtime/Map/TableMap.php and 1 other location - About 40 mins to fix
                src/Propel/Runtime/Map/TableMap.php on lines 673..684

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 94.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status