Showing 7 of 7 total issues
Method pkgng_active? has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def pkgng_active?(options = {})
return @pkgng_active unless @pkgng_active.nil?
pkg = options[:pkg] || (respond_to?(:command) ? command(:pkg) : nil)
# Detect whether the OS uses old pkg or the new pkgng.- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method save has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def save(file,params={})
dir = File.dirname(file)
if not File.exists?(dir)
msg = "Creating directory #{dir}"
respond_to?(:debug) ? debug(msg) : Puppet.debug(msg)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method search_packages_1 has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def search_packages_1(names, fields, options)
merge = names ? lambda {|r1,r2| r1[1].merge!(r2[1]) } :
lambda {|r1,r2| r1.merge!(r2) }
# sometimes we have to call portversion twice (perform two passes),
# pass1 and pass2 contain arguments for search_packages_2 for the first- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method load has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def self.load(files,params={})
files = [files] unless files.is_a?(Array)
# concatenate all files in order ...
contents = []
files.each do|file|- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method do_search_ports has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
def do_search_ports(key, names, fields, options, nextnames=nil)Method search_ports_by has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def search_ports_by(key, values, fields=PortRecord.default_fields, options={})
key = key.downcase.intern unless key.instance_of?(Symbol)
search_key = determine_search_key(key)
delete_key = if fields.include?(key)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method each_paragraph_of has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def each_paragraph_of(input)
paragraph = ''
has_lines = false
input.each_line do |line|
if line =~ /^\s*\n?$/- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"