Sign upLogin

publiclab/plots2

View on GitHub
Star
app/controllers/editor_controller.rb

Summary

Maintainability
A
45 mins
Test Coverage

Method rich has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def rich
    if params[:main_image] && Image.find_by(id: params[:main_image])
      @main_image = Image.find_by(id: params[:main_image]).path
    end
Severity: Minor
Found in app/controllers/editor_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Use parentheses in the method call to avoid confusion about precedence.
Open

        x.include? "lon:" && (@lon = x.split(':')[1])
Severity: Minor
Found in app/controllers/editor_controller.rb by rubocop

This cop checks for expressions where there is a call to a predicate method with at least one argument, where no parentheses are used around the parameter list, and a boolean operator, && or ||, is used in the last argument.

The idea behind warning for these constructs is that the user might be under the impression that the return value from the method call is an operand of &&/||.

Example:

# bad

if day.is? :tuesday && month == :jan
  # ...
end

Example:

# good

if day.is?(:tuesday) && month == :jan
  # ...
end

Use parentheses in the method call to avoid confusion about precedence.
Open

        x.include? "zoom:" && (@zoom = x.split(':')[1])
Severity: Minor
Found in app/controllers/editor_controller.rb by rubocop

This cop checks for expressions where there is a call to a predicate method with at least one argument, where no parentheses are used around the parameter list, and a boolean operator, && or ||, is used in the last argument.

The idea behind warning for these constructs is that the user might be under the impression that the return value from the method call is an operand of &&/||.

Example:

# bad

if day.is? :tuesday && month == :jan
  # ...
end

Example:

# good

if day.is?(:tuesday) && month == :jan
  # ...
end

Use parentheses in the method call to avoid confusion about precedence.
Open

        x.include? "lat:" && (@lat = x.split(':')[1])
Severity: Minor
Found in app/controllers/editor_controller.rb by rubocop

This cop checks for expressions where there is a call to a predicate method with at least one argument, where no parentheses are used around the parameter list, and a boolean operator, && or ||, is used in the last argument.

The idea behind warning for these constructs is that the user might be under the impression that the return value from the method call is an operand of &&/||.

Example:

# bad

if day.is? :tuesday && month == :jan
  # ...
end

Example:

# good

if day.is?(:tuesday) && month == :jan
  # ...
end

There are no issues that match your filters.

Category
Status