Sign upLogin

publiclab/plots2

View on GitHub
Star
app/controllers/map_controller.rb

Summary

Maintainability
A
35 mins
Test Coverage

Method wiki has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def wiki
    @node = Node.find_wiki(params[:id])

    if @node.blank? || @node.has_power_tag("lat").blank? || @node.has_power_tag("lon").blank?
      flash[:warning] = @node.blank? ? "Wiki page not found." : "No location found for wiki page."
Severity: Minor
Found in app/controllers/map_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Extra empty line detected at class body end.
Open


end
Severity: Minor
Found in app/controllers/map_controller.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

There are no issues that match your filters.

Category
Status