pug-php/pug-symfony

View on GitHub

Showing 287 of 287 total issues

Avoid variables with short names like $io. Configured minimum length is 3.
Open

        $io = $event->getIO();
Severity: Minor
Found in src/Pug/Symfony/Traits/Installer.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $io. Configured minimum length is 3.
Open

    protected static function askConfirmation(IOInterface $io, $message)
Severity: Minor
Found in src/Pug/Symfony/Traits/Installer.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $io. Configured minimum length is 3.
Open

        $io = $event->getIO();
Severity: Minor
Found in src/Pug/Symfony/Traits/Installer.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Method installSymfonyBundle has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    protected static function installSymfonyBundle(IOInterface $io, $dir, $bundle, $bundleClass, $proceedTask, &$flags)
Severity: Minor
Found in src/Pug/Symfony/Traits/Installer.php - About 45 mins to fix

    Method proceedTask has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static function proceedTask(&$flags, $io, $taskResult, $flag, $successMessage, $message)
    Severity: Minor
    Found in src/Pug/Symfony/Traits/Installer.php - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if ($newLine > $templateLine) {
                                      $templateLine = $newLine;
                                      $debugInfo[$codeFirstLine + $index] = $newLine;
                                  }
      Severity: Major
      Found in src/Pug/Twig/Environment.php - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                switch ($tokens[$index]) {
                                    case '(':
                                        $opening++;
                                        $argumentNeedInterpolation = true;
                                        $argument .= '(';
        Severity: Major
        Found in src/Pug/Symfony/Traits/HelpersHandler.php - About 45 mins to fix

          Function copyTwigFunctions has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function copyTwigFunctions(): void
              {
                  $this->twigHelpers = [];
                  $twig = $this->getTwig();
                  $twig->env = $twig;
          Severity: Minor
          Found in src/Pug/Symfony/Traits/HelpersHandler.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Remove error control operator '@' on line 22.
          Open

              protected static function installSymfonyBundle(IOInterface $io, $dir, $bundle, $bundleClass, $proceedTask, &$flags)
              {
                  $appFile = $dir.'/config/bundles.php';
                  $contents = @file_get_contents($appFile) ?: '';
          
          
          Severity: Minor
          Found in src/Pug/Symfony/Traits/Installer.php by phpmd

          ErrorControlOperator

          Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

          Example

          function foo($filePath) {
              $file = @fopen($filPath); // hides exceptions
              $key = @$array[$notExistingKey]; // assigns null to $key
          }

          Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

          Duplicated array key {{filename}}, first declared at line 177.
          Open

                      $replacements = [
                          $fileName               => $className,
                          '"{{filename}}"'        => var_export($name, true),
                          '{{filename}}'          => $name,
                          '"{{path}}"'            => var_export($path, true),
          Severity: Minor
          Found in src/Pug/Twig/Environment.php by phpmd

          DuplicatedArrayKey

          Defining another value for the same key in an array literal overrides the previous key/value, which makes it effectively an unused code. If it's known from the beginning that the key will have different value, there is usually no point in defining first one.

          Example

          function createArray() {
              return [
                  'non-associative 0element', // not applied
                  0 => 'associative 0-element', // applied
                  false => 'associative 0-element', // applied
                  'foo' => 'bar', // not applied
                  "foo" => 'baz', // applied
              ];
          }

          Source http://phpmd.org/rules/cleancode.html#duplicatedarraykey

          Avoid assigning values to variables in if clauses and the like (line '103', column '18').
          Open

              protected function getRendererOptions(): array
              {
                  if ($this->options === null) {
                      $environment = $this->kernel->getEnvironment();
                      $projectDirectory = $this->kernel->getProjectDir();

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($foo = 'bar') { // possible typo
                      // ...
                  }
                  if ($baz = 0) { // always false
                      // ...
                  }
              }
          }

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid assigning values to variables in if clauses and the like (line '84', column '28').
          Open

              protected function crawlDirectories(string $srcDir, array &$assetsDirectories, array &$viewDirectories): ?string
              {
                  $baseDir = file_exists($viewDirectories[0]) ? $viewDirectories[0] : null;
          
                  if (file_exists($srcDir)) {
          Severity: Minor
          Found in src/Pug/PugSymfonyEngine.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($foo = 'bar') { // possible typo
                      // ...
                  }
                  if ($baz = 0) { // always false
                      // ...
                  }
              }
          }

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid assigning values to variables in if clauses and the like (line '104', column '26').
          Open

              protected function getRendererOptions(): array
              {
                  if ($this->options === null) {
                      $environment = $this->kernel->getEnvironment();
                      $projectDirectory = $this->kernel->getProjectDir();

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($foo = 'bar') { // possible typo
                      // ...
                  }
                  if ($baz = 0) { // always false
                      // ...
                  }
              }
          }

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          Avoid unused local variables such as '$arguments'.
          Open

                  $arguments[] = $name;
          Severity: Minor
          Found in src/Pug/Twig/Environment.php by phpmd

          UnusedLocalVariable

          Since: 0.2

          Detects when a local variable is declared and/or assigned, but not used.

          Example

          class Foo {
              public function doSomething()
              {
                  $i = 5; // Unused
              }
          }

          Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

          The method installInSymfony5 uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
                      $flags |= InstallerInterface::KERNEL_OK;
                  }
          Severity: Minor
          Found in src/Pug/Symfony/Traits/Installer.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($flag) {
                      // one branch
                  } else {
                      // another branch
                  }
              }
          }

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid assigning values to variables in if clauses and the like (line '110', column '17').
          Open

              protected function getFileFromName(string $name, string $directory = null): string
              {
                  $parts = explode(':', strval($name));
          
                  if (count($parts) > 1) {
          Severity: Minor
          Found in src/Pug/PugSymfonyEngine.php by phpmd

          IfStatementAssignment

          Since: 2.7.0

          Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

          Example

          class Foo
          {
              public function bar($flag)
              {
                  if ($foo = 'bar') { // possible typo
                      // ...
                  }
                  if ($baz = 0) { // always false
                      // ...
                  }
              }
          }

          Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

          The method getRendererOptions() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
          Open

              protected function getRendererOptions(): array
              {
                  if ($this->options === null) {
                      $environment = $this->kernel->getEnvironment();
                      $projectDirectory = $this->kernel->getProjectDir();

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The method compileSource() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
          Open

              public function compileSource(Source $source): string
              {
                  $path = $source->getPath();
          
                  if ($this->pugSymfonyEngine->supports($path)) {
          Severity: Minor
          Found in src/Pug/Twig/Environment.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The method interpolateTwigFunctions() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10.
          Open

              protected function interpolateTwigFunctions(string $code): string
              {
                  $tokens = array_slice(token_get_all('<?php '.$code), 1);
                  $output = '';
                  $count = count($tokens);

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          The method crawlDirectories() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
          Open

              protected function crawlDirectories(string $srcDir, array &$assetsDirectories, array &$viewDirectories): ?string
              {
                  $baseDir = file_exists($viewDirectories[0]) ? $viewDirectories[0] : null;
          
                  if (file_exists($srcDir)) {
          Severity: Minor
          Found in src/Pug/PugSymfonyEngine.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
          class Foo {
          1   public function example() {
          2       if ($a == $b) {
          3           if ($a1 == $b1) {
                          fiddle();
          4           } elseif ($a2 == $b2) {
                          fiddle();
                      } else {
                          fiddle();
                      }
          5       } elseif ($c == $d) {
          6           while ($c == $d) {
                          fiddle();
                      }
          7        } elseif ($e == $f) {
          8           for ($n = 0; $n < $h; $n++) {
                          fiddle();
                      }
                  } else {
                      switch ($z) {
          9               case 1:
                              fiddle();
                              break;
          10              case 2:
                              fiddle();
                              break;
          11              case 3:
                              fiddle();
                              break;
                          default:
                              fiddle();
                              break;
                      }
                  }
              }
          }

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Severity
          Category
          Status
          Source
          Language