pug-php/twig

View on GitHub

Showing 146 of 146 total issues

The class TwigXmlFormat has an overall complexity of 51 which is very high. The configured complexity threshold is 50.
Open

class TwigXmlFormat extends AbstractTwigFormat
{
    use AssignmentHelpersTrait;

    const DOCTYPE = '<?xml version="1.0" encoding="utf-8" ?>';

Method __construct has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct(Formatter $formatter = null)
    {
        $this->setOptionsRecursive([
            'white_space_sensitive_tags' => [
                'pre',
Severity: Major
Found in src/Phug/Formatter/Format/TwigXhtmlFormat.php - About 2 hrs to fix

    Function formatAttributeElement has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function formatAttributeElement(AttributeElement $element)
        {
            $value = $element->getValue();
            $name = $element->getName();
            $nonEmptyAttribute = ($name === 'class' || $name === 'id');
    Severity: Minor
    Found in src/Phug/Formatter/Format/TwigXmlFormat.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method formatAssignmentElement has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function formatAssignmentElement(AssignmentElement $element)
        {
            $handlers = $this->getOption('assignment_handlers');
            $newElements = [];
            array_walk(
    Severity: Minor
    Found in src/Phug/Formatter/Format/TwigXmlFormat.php - About 1 hr to fix

      Method __construct has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct(Formatter $formatter = null)
          {
              parent::__construct($formatter);
      
              $this->codeBlocks = [];
      Severity: Minor
      Found in src/Phug/Formatter/AbstractTwigFormat.php - About 1 hr to fix

        Function isBlockTag has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function isBlockTag(MarkupInterface $element)
            {
                if ($element->belongsTo($this->getOption('inline_tags'))) {
                    return false;
                }
        Severity: Minor
        Found in src/Phug/Formatter/Format/TwigXhtmlFormat.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct(Formatter $formatter = null)
            {
                parent::__construct($formatter);
        
                $defaults = [];
        Severity: Minor
        Found in src/Phug/Formatter/Format/TwigXmlFormat.php - About 1 hr to fix

          Avoid too many return statements within this method.
          Open

                  return $this->pattern(
                      'attribute_pattern',
                      $this->format($name),
                      $this->format($value)
                  );
          Severity: Major
          Found in src/Phug/Formatter/Format/TwigXmlFormat.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return '';
            Severity: Major
            Found in src/Phug/Formatter/Format/TwigXmlFormat.php - About 30 mins to fix

              The method isSelfClosingTag has a boolean flag argument $isSelfClosing, which is a certain sign of a Single Responsibility Principle violation.
              Open

                  public function isSelfClosingTag(MarkupInterface $element, $isSelfClosing = false)

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
                  public function bar($flag = true) {
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              Avoid too many return statements within this method.
              Open

                                  return "{{ $input }}";
              Severity: Major
              Found in src/Phug/Formatter/AbstractTwigFormat.php - About 30 mins to fix

                Avoid unused parameters such as '$element'.
                Open

                    public function isWhiteSpaceSensitive(MarkupInterface $element)

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
                {
                    private function bar($howdy)
                    {
                        // $howdy is not used
                    }
                }

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                The method formatAttributeElement() has an NPath complexity of 325. The configured NPath complexity threshold is 200.
                Open

                    protected function formatAttributeElement(AttributeElement $element)
                    {
                        $value = $element->getValue();
                        $name = $element->getName();
                        $nonEmptyAttribute = ($name === 'class' || $name === 'id');

                NPathComplexity

                Since: 0.1

                The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

                Example

                class Foo {
                    function bar() {
                        // lots of complicated code
                    }
                }

                Source https://phpmd.org/rules/codesize.html#npathcomplexity

                Avoid assigning values to variables in if clauses and the like (line '111', column '18').
                Open

                    protected function deduplicatePhpTags($commentPattern, &$content, &$childContent)
                    {
                        $content = preg_replace('/\\s\\?>$/', '', $content);
                        $childContent = preg_replace('/^<\\?(?:php)?\\s/', '', $childContent);
                        if ($commentPattern &&

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($foo = 'bar') { // possible typo
                            // ...
                        }
                        if ($baz = 0) { // always false
                            // ...
                        }
                    }
                }

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                Avoid using static access to class 'Phug\PugToTwig' in method '__construct'.
                Open

                        PugToTwig::enableTwigFormatter($container);
                Severity: Minor
                Found in src/Phug/TwigExtension.php by phpmd

                StaticAccess

                Since: 1.4.0

                Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

                Example

                class Foo
                {
                    public function bar()
                    {
                        Bar::baz();
                    }
                }

                Source https://phpmd.org/rules/cleancode.html#staticaccess

                Avoid assigning values to variables in if clauses and the like (line '110', column '14').
                Open

                    protected function deduplicatePhpTags($commentPattern, &$content, &$childContent)
                    {
                        $content = preg_replace('/\\s\\?>$/', '', $content);
                        $childContent = preg_replace('/^<\\?(?:php)?\\s/', '', $childContent);
                        if ($commentPattern &&

                IfStatementAssignment

                Since: 2.7.0

                Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

                Example

                class Foo
                {
                    public function bar($flag)
                    {
                        if ($foo = 'bar') { // possible typo
                            // ...
                        }
                        if ($baz = 0) { // always false
                            // ...
                        }
                    }
                }

                Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

                Avoid unused parameters such as '$element'.
                Open

                    protected function isBlockTag(MarkupInterface $element)

                UnusedFormalParameter

                Since: 0.2

                Avoid passing parameters to methods or constructors and then not using those parameters.

                Example

                class Foo
                {
                    private function bar($howdy)
                    {
                        // $howdy is not used
                    }
                }

                Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

                The method formatAttributeElement() has a Cyclomatic Complexity of 15. The configured cyclomatic complexity threshold is 10.
                Open

                    protected function formatAttributeElement(AttributeElement $element)
                    {
                        $value = $element->getValue();
                        $name = $element->getName();
                        $nonEmptyAttribute = ($name === 'class' || $name === 'id');

                CyclomaticComplexity

                Since: 0.1

                Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

                Example

                // Cyclomatic Complexity = 11
                class Foo {
                1   public function example() {
                2       if ($a == $b) {
                3           if ($a1 == $b1) {
                                fiddle();
                4           } elseif ($a2 == $b2) {
                                fiddle();
                            } else {
                                fiddle();
                            }
                5       } elseif ($c == $d) {
                6           while ($c == $d) {
                                fiddle();
                            }
                7        } elseif ($e == $f) {
                8           for ($n = 0; $n < $h; $n++) {
                                fiddle();
                            }
                        } else {
                            switch ($z) {
                9               case 1:
                                    fiddle();
                                    break;
                10              case 2:
                                    fiddle();
                                    break;
                11              case 3:
                                    fiddle();
                                    break;
                                default:
                                    fiddle();
                                    break;
                            }
                        }
                    }
                }

                Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

                Call to undeclared method \Phug\Formatter\AbstractTwigFormat::setOptionsRecursive
                Open

                        $this
                Severity: Critical
                Found in src/Phug/Formatter/AbstractTwigFormat.php by phan

                Reference to undeclared property \Phug\Formatter\AbstractTwigFormat->formatter
                Open

                                    $pugModuleName = '$'.$this->formatter->getOption('dependencies_storage');
                Severity
                Category
                Status
                Source
                Language