Sign upLogin

pug-php/twig

View on GitHub
Star
src/Phug/TwigExtension.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid using static access to class 'Phug\PugToTwig' in method '__construct'.
Open

        PugToTwig::enableTwigFormatter($container);
Severity: Minor
Found in src/Phug/TwigExtension.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Class extends undeclared class \Phug\AbstractCompilerModule
Open

class TwigExtension extends AbstractCompilerModule
Severity: Critical
Found in src/Phug/TwigExtension.php by phan

Reference to undeclared class \Phug\AbstractCompilerModule
Open

        parent::__construct($container);
Severity: Critical
Found in src/Phug/TwigExtension.php by phan

Parameter $container has undeclared type \Phug\Util\ModuleContainerInterface
Open

    public function __construct(ModuleContainerInterface $container)
Severity: Minor
Found in src/Phug/TwigExtension.php by phan

Checking instanceof against undeclared class \Phug\Renderer
Open

        if ($container instanceof Renderer) {
Severity: Critical
Found in src/Phug/TwigExtension.php by phan

Argument 1 (compiler) is \Phug\Util\ModuleContainerInterface but \Phug\PugToTwig::enableTwigFormatter() takes \Phug\CompilerInterface defined at /code/src/Phug/PugToTwig.php:42
Open

        PugToTwig::enableTwigFormatter($container);
Severity: Minor
Found in src/Phug/TwigExtension.php by phan

There are no issues that match your filters.

Category
Status