puphpet/puphpet

View on GitHub

Showing 43 of 43 total issues

Method __construct has 316 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct()
    {
        /* mandatory requirements follow */

        $installedPhpVersion = phpversion();
Severity: Major
Found in app/SymfonyRequirements.php - About 1 day to fix

    File SymfonyRequirements.php has 514 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /*
     * This file is part of the Symfony package.
     *
    Severity: Major
    Found in app/SymfonyRequirements.php - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function getCacheDir()
          {
              if (static::$cacheDir) {
                  return static::$cacheDir;
              }
      Severity: Major
      Found in app/AppKernel.php and 1 other location - About 7 hrs to fix
      app/AppKernel.php on lines 70..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 242.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function getLogDir()
          {
              if (static::$logDir) {
                  return static::$logDir;
              }
      Severity: Major
      Found in app/AppKernel.php and 1 other location - About 7 hrs to fix
      app/AppKernel.php on lines 41..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 242.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File custom.js has 453 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      var PUPHPET = {};
      
      /**
       * Catches anchor tag (#foo) in URL bar and displays proper tab
       */
      Severity: Minor
      Found in src/PuphpetBundle/Resources/public/custom.js - About 6 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        <?php
        
        namespace PuphpetBundle\Controller;
        
        use PuphpetBundle\Controller;
        Severity: Major
        Found in src/PuphpetBundle/Controller/MariaDbController.php and 1 other location - About 6 hrs to fix
        src/PuphpetBundle/Controller/MySqlController.php on lines 1..81

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 215.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        <?php
        
        namespace PuphpetBundle\Controller;
        
        use PuphpetBundle\Controller;
        Severity: Major
        Found in src/PuphpetBundle/Controller/MySqlController.php and 1 other location - About 6 hrs to fix
        src/PuphpetBundle/Controller/MariaDbController.php on lines 1..81

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 215.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function __construct has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
        Open

            public function __construct()
            {
                /* mandatory requirements follow */
        
                $installedPhpVersion = phpversion();
        Severity: Minor
        Found in app/SymfonyRequirements.php - About 6 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        <?php
        
        namespace PuphpetBundle\Controller;
        
        use PuphpetBundle\Controller;
        Severity: Major
        Found in src/PuphpetBundle/Controller/VagrantfileGceController.php and 4 other locations - About 3 hrs to fix
        src/PuphpetBundle/Controller/VagrantfileAwsController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileDigitalOceanController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileLinodeController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileRackspaceController.php on lines 1..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        <?php
        
        namespace PuphpetBundle\Controller;
        
        use PuphpetBundle\Controller;
        Severity: Major
        Found in src/PuphpetBundle/Controller/VagrantfileAwsController.php and 4 other locations - About 3 hrs to fix
        src/PuphpetBundle/Controller/VagrantfileDigitalOceanController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileGceController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileLinodeController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileRackspaceController.php on lines 1..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        <?php
        
        namespace PuphpetBundle\Controller;
        
        use PuphpetBundle\Controller;
        src/PuphpetBundle/Controller/VagrantfileAwsController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileGceController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileLinodeController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileRackspaceController.php on lines 1..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        <?php
        
        namespace PuphpetBundle\Controller;
        
        use PuphpetBundle\Controller;
        src/PuphpetBundle/Controller/VagrantfileAwsController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileDigitalOceanController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileGceController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileRackspaceController.php on lines 1..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

        <?php
        
        namespace PuphpetBundle\Controller;
        
        use PuphpetBundle\Controller;
        src/PuphpetBundle/Controller/VagrantfileAwsController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileDigitalOceanController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileGceController.php on lines 1..63
        src/PuphpetBundle/Controller/VagrantfileLinodeController.php on lines 1..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function uploadConfig has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        PUPHPET.uploadConfig = function() {
            var dropzone = document.documentElement;
            var tid;
        
            dropzone.addEventListener('dragover', handleDragOver, false);
        Severity: Major
        Found in src/PuphpetBundle/Resources/public/custom.js - About 2 hrs to fix

          Function addBlock has 55 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          PUPHPET.addBlock = function() {
              $(document).on('click', '[data-toggle="add-block"]', function(e){
                  e.stopPropagation();
                  e.preventDefault && e.preventDefault();
          
          
          Severity: Major
          Found in src/PuphpetBundle/Resources/public/custom.js - About 2 hrs to fix

            Function selectizeTagsUserInput has 50 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            PUPHPET.selectizeTagsUserInput = function($element) {
                var $selectTagsUserInput = $('.select-tags-user-input', $element).selectize({
                    plugins: ['remove_button'],
                    delimiter: ',',
                    persist: false,
            Severity: Minor
            Found in src/PuphpetBundle/Resources/public/custom.js - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              PUPHPET.enableFormElements = function($container) {
                  $container.removeClass('form-elements-disabled');
              
                  $container.each(function() {
                      $(this)
              Severity: Major
              Found in src/PuphpetBundle/Resources/public/custom.js and 1 other location - About 1 hr to fix
              src/PuphpetBundle/Resources/public/custom.js on lines 514..522

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              PUPHPET.disableFormElements = function($container) {
                  $container.addClass('form-elements-disabled');
              
                  $container.each(function() {
                      $(this)
              Severity: Major
              Found in src/PuphpetBundle/Resources/public/custom.js and 1 other location - About 1 hr to fix
              src/PuphpetBundle/Resources/public/custom.js on lines 527..535

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 72.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method postUploadConfigAction has 44 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function postUploadConfigAction(Request $request)
                  {
                      $config = Helper\DataTransform::normalizeLineBreaks($request->get('config'));
              
                      $session = $this->getSession();
              Severity: Minor
              Found in src/PuphpetBundle/Controller/FrontController.php - About 1 hr to fix

                Function runSelectize has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                PUPHPET.runSelectize = function($element) {
                    // input or select elements; allows user to create their own tags
                    var $selectTagsEditable = $('.tags, .select-tags-editable', $element).selectize({
                        plugins: ['remove_button'],
                        delimiter: ',',
                Severity: Minor
                Found in src/PuphpetBundle/Resources/public/custom.js - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language