qmuntal/gltf

View on GitHub

Showing 21 of 46 total issues

Function Type has 94 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func Type(data interface{}) (c gltf.ComponentType, t gltf.AccessorType, count uint32) {
    v := reflect.ValueOf(data)
    if v.Kind() != reflect.Slice {
        panic(fmt.Sprintf("go3mf: binary.Type expecting a slice but got %s", v.Kind()))
    }
Severity: Major
Found in binary/slice.go - About 2 hrs to fix

    Function ReadColor has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

    func ReadColor(doc *gltf.Document, acr *gltf.Accessor, buffer [][4]uint8) ([][4]uint8, error) {
        switch acr.ComponentType {
        case gltf.ComponentUbyte, gltf.ComponentUshort, gltf.ComponentFloat:
        default:
            return nil, errComponentType(acr.ComponentType)
    Severity: Minor
    Found in modeler/read.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function ReadColor64 has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
    Open

    func ReadColor64(doc *gltf.Document, acr *gltf.Accessor, buffer [][4]uint16) ([][4]uint16, error) {
        switch acr.ComponentType {
        case gltf.ComponentUbyte, gltf.ComponentUshort, gltf.ComponentFloat:
        default:
            return nil, errComponentType(acr.ComponentType)
    Severity: Minor
    Found in modeler/read.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function WriteAttributesInterleaved has 67 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func WriteAttributesInterleaved(doc *gltf.Document, v Attributes) (map[string]uint32, error) {
        type attrProps struct {
            Name       string
            Normalized bool
        }
    Severity: Minor
    Found in modeler/write.go - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func ReadPosition(doc *gltf.Document, acr *gltf.Accessor, buffer [][3]float32) ([][3]float32, error) {
          if acr.ComponentType != gltf.ComponentFloat {
              return nil, errComponentType(acr.ComponentType)
          }
          if acr.Type != gltf.AccessorVec3 {
      Severity: Major
      Found in modeler/read.go and 2 other locations - About 1 hr to fix
      modeler/read.go on lines 141..153
      modeler/read.go on lines 158..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 165.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func ReadTangent(doc *gltf.Document, acr *gltf.Accessor, buffer [][4]float32) ([][4]float32, error) {
          if acr.ComponentType != gltf.ComponentFloat {
              return nil, errComponentType(acr.ComponentType)
          }
          if acr.Type != gltf.AccessorVec4 {
      Severity: Major
      Found in modeler/read.go and 2 other locations - About 1 hr to fix
      modeler/read.go on lines 141..153
      modeler/read.go on lines 292..304

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 165.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

      func ReadNormal(doc *gltf.Document, acr *gltf.Accessor, buffer [][3]float32) ([][3]float32, error) {
          if acr.ComponentType != gltf.ComponentFloat {
              return nil, errComponentType(acr.ComponentType)
          }
          if acr.Type != gltf.AccessorVec3 {
      Severity: Major
      Found in modeler/read.go and 2 other locations - About 1 hr to fix
      modeler/read.go on lines 158..170
      modeler/read.go on lines 292..304

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 165.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (n *NormalTexture) MarshalJSON() ([]byte, error) {
          type alias NormalTexture
          if n.Scale != nil && *n.Scale == 1 {
              return json.Marshal(&struct {
                  Scale float32 `json:"scale,omitempty"`
      Severity: Major
      Found in encode.go and 1 other location - About 1 hr to fix
      encode.go on lines 291..303

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 158.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (o *OcclusionTexture) MarshalJSON() ([]byte, error) {
          type alias OcclusionTexture
          if o.Strength != nil && *o.Strength == 1 {
              return json.Marshal(&struct {
                  Strength float32 `json:"strength,omitempty"`
      Severity: Major
      Found in encode.go and 1 other location - About 1 hr to fix
      encode.go on lines 265..277

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 158.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function ReadColor64 has 58 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func ReadColor64(doc *gltf.Document, acr *gltf.Accessor, buffer [][4]uint16) ([][4]uint16, error) {
          switch acr.ComponentType {
          case gltf.ComponentUbyte, gltf.ComponentUshort, gltf.ComponentFloat:
          default:
              return nil, errComponentType(acr.ComponentType)
      Severity: Minor
      Found in modeler/read.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case gltf.ComponentFloat:
                if acr.Type == gltf.AccessorVec3 {
                    for i, e := range data.([][3]float32) {
                        tmp := gltf.NormalizeRGB64(e)
                        buffer[i] = [4]uint16{tmp[0], tmp[1], tmp[2], 65535}
        Severity: Major
        Found in modeler/read.go and 1 other location - About 1 hr to fix
        modeler/read.go on lines 348..358

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 131.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            case gltf.ComponentFloat:
                if acr.Type == gltf.AccessorVec3 {
                    for i, e := range data.([][3]float32) {
                        tmp := gltf.NormalizeRGB(e)
                        buffer[i] = [4]uint8{tmp[0], tmp[1], tmp[2], 255}
        Severity: Major
        Found in modeler/read.go and 1 other location - About 1 hr to fix
        modeler/read.go on lines 414..424

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 131.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function ReadAccessor has 8 return statements (exceeds 4 allowed).
        Open

        func ReadAccessor(doc *gltf.Document, acr *gltf.Accessor, buffer interface{}) (interface{}, error) {
            if acr.BufferView == nil && acr.Sparse == nil {
                return nil, nil
            }
            buffer = binary.MakeSliceBuffer(acr.ComponentType, acr.Type, acr.Count, buffer)
        Severity: Major
        Found in modeler/read.go - About 50 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func NormalizeRGBA(v [4]float32) [4]uint8 {
              return [4]uint8{
                  uint8(deliniarize(v[0]) * 255),
                  uint8(deliniarize(v[1]) * 255),
                  uint8(deliniarize(v[2]) * 255),
          Severity: Minor
          Found in math.go and 1 other location - About 40 mins to fix
          math.go on lines 109..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func NormalizeRGBA64(v [4]float32) [4]uint16 {
              return [4]uint16{
                  uint16(deliniarize(v[0]) * 65535),
                  uint16(deliniarize(v[1]) * 65535),
                  uint16(deliniarize(v[2]) * 65535),
          Severity: Minor
          Found in math.go and 1 other location - About 40 mins to fix
          math.go on lines 67..74

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func DenormalizeRGBA64(v [4]uint16) [4]float32 {
              return [4]float32{
                  linearize(float32(v[0]) / 65535),
                  linearize(float32(v[1]) / 65535),
                  linearize(float32(v[2]) / 65535),
          Severity: Minor
          Found in math.go and 1 other location - About 40 mins to fix
          math.go on lines 78..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func DenormalizeRGBA(v [4]uint8) [4]float32 {
              return [4]float32{
                  linearize(float32(v[0]) / 255),
                  linearize(float32(v[1]) / 255),
                  linearize(float32(v[2]) / 255),
          Severity: Minor
          Found in math.go and 1 other location - About 40 mins to fix
          math.go on lines 120..127

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 109.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          func (n *NormalTexture) UnmarshalJSON(data []byte) error {
              type alias NormalTexture
              tmp := alias(NormalTexture{Scale: Float(1)})
              err := json.Unmarshal(data, &tmp)
              if err == nil {
          Severity: Minor
          Found in encode.go and 2 other locations - About 40 mins to fix
          encode.go on lines 227..235
          encode.go on lines 280..288

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          func (o *OcclusionTexture) UnmarshalJSON(data []byte) error {
              type alias OcclusionTexture
              tmp := alias(OcclusionTexture{Strength: Float(1)})
              err := json.Unmarshal(data, &tmp)
              if err == nil {
          Severity: Minor
          Found in encode.go and 2 other locations - About 40 mins to fix
          encode.go on lines 227..235
          encode.go on lines 254..262

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

          func (m *Material) UnmarshalJSON(data []byte) error {
              type alias Material
              tmp := alias(Material{AlphaCutoff: Float(0.5)})
              err := json.Unmarshal(data, &tmp)
              if err == nil {
          Severity: Minor
          Found in encode.go and 2 other locations - About 40 mins to fix
          encode.go on lines 254..262
          encode.go on lines 280..288

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 108.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language