qmuntal/gltf

View on GitHub

Showing 26 of 49 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func DenormalizeRGBA64(v [4]uint16) [4]float32 {
    return [4]float32{
        linearize(float32(v[0]) / 65535),
        linearize(float32(v[1]) / 65535),
        linearize(float32(v[2]) / 65535),
Severity: Minor
Found in math.go and 1 other location - About 40 mins to fix
math.go on lines 78..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func (n *NormalTexture) UnmarshalJSON(data []byte) error {
    type alias NormalTexture
    tmp := alias(NormalTexture{Scale: Float(1)})
    err := json.Unmarshal(data, &tmp)
    if err == nil {
Severity: Minor
Found in encode.go and 2 other locations - About 40 mins to fix
encode.go on lines 317..325
encode.go on lines 373..381

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func (o *OcclusionTexture) UnmarshalJSON(data []byte) error {
    type alias OcclusionTexture
    tmp := alias(OcclusionTexture{Strength: Float(1)})
    err := json.Unmarshal(data, &tmp)
    if err == nil {
Severity: Minor
Found in encode.go and 2 other locations - About 40 mins to fix
encode.go on lines 317..325
encode.go on lines 347..355

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func (m *Material) UnmarshalJSON(data []byte) error {
    type alias Material
    tmp := alias(Material{AlphaCutoff: Float(0.5)})
    err := json.Unmarshal(data, &tmp)
    if err == nil {
Severity: Minor
Found in encode.go and 2 other locations - About 40 mins to fix
encode.go on lines 347..355
encode.go on lines 373..381

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 108.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function MakeSliceBuffer has 5 return statements (exceeds 4 allowed).
Open

func MakeSliceBuffer(c gltf.ComponentType, t gltf.AccessorType, count uint32, buffer interface{}) interface{} {
    if buffer == nil {
        return MakeSlice(c, t, count)
    }
    c1, t1, count1 := Type(buffer)
Severity: Major
Found in binary/slice.go - About 35 mins to fix

    Method Encoder.encodeBuffer has 5 return statements (exceeds 4 allowed).
    Open

    func (e *Encoder) encodeBuffer(buffer *Buffer) error {
        if err := validateBufferURI(buffer.URI); err != nil {
            return err
        }
        if e.Fsys == nil {
    Severity: Major
    Found in encode.go - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language