quorrajs/Ouch

View on GitHub

Showing 12 of 12 total issues

Function frame has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

function frame(frame) {
    frame.__comments = [];
    frame.__proto__ = {
        __proto__: frame.__proto__,

Severity: Minor
Found in exception/frame.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function frame has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function frame(frame) {
    frame.__comments = [];
    frame.__proto__ = {
        __proto__: frame.__proto__,

Severity: Major
Found in exception/frame.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    JsonResponseHandler.prototype.__wantsJson = function () {
        if (this.__request) {
            return (
            !_.isEmpty(this.__request.headers['accept'])
            && (this.__request.headers['accept']).toLowerCase() == 'application/json');
    Severity: Major
    Found in handler/JsonResponseHandler.js and 1 other location - About 2 hrs to fix
    handler/JsonResponseHandler.js on lines 57..63

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    JsonResponseHandler.prototype.__isAjaxRequest = function () {
        if (this.__request) {
            return (
            !_.isEmpty(this.__request.headers['x-requested-with'])
            && (this.__request.headers['x-requested-with']).toLowerCase() == 'xmlhttprequest');
    Severity: Major
    Found in handler/JsonResponseHandler.js and 1 other location - About 2 hrs to fix
    handler/JsonResponseHandler.js on lines 71..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 87.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function handle has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    PrettyPageHandler.prototype.handle = function (next) {
    
        var helper = new TemplateHelper();
    
        var templateFile = this.__getResource("views/layout.ejs");
    Severity: Minor
    Found in handler/PrettyPageHandler.js - About 1 hr to fix

      Function app has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      http.createServer(function app(req, res) {
      
          if (req.url === '/favicon.ico') {
              res.writeHead(200, {'Content-Type': 'image/x-icon'});
              res.end();
      Severity: Minor
      Found in examples/example-comments.js - About 1 hr to fix

        Function handleException has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Ouch.prototype.handleException = function (exception, request, response, CB) {
            if (!request) {
                request = null;
            }
        
        
        Severity: Minor
        Found in Ouch.js - About 1 hr to fix

          Function handle has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          JsonResponseHandler.prototype.handle = function (next) {
              if (this.__onlyForAjaxOrJsonRequests && !(this.__isAjaxRequest() || this.__wantsJson())) {
                  next();
              } else {
          
          
          Severity: Minor
          Found in handler/JsonResponseHandler.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              d.run(function () {
          
                  // your application code goes here
          
                  // this will throw error
          Severity: Minor
          Found in examples/example-comments.js and 1 other location - About 50 mins to fix
          examples/example-jsonAndPretty.js on lines 43..53

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              d.run(function(){
          
                  // your application code goes here
          
                  // this will throw error
          Severity: Minor
          Found in examples/example-jsonAndPretty.js and 1 other location - About 50 mins to fix
          examples/example-comments.js on lines 50..60

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function PrettyPageHandler has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          function PrettyPageHandler(theme, pageTitle, editor, sendResponse, additionalScripts) {
          Severity: Minor
          Found in handler/PrettyPageHandler.js - About 35 mins to fix

            Function handle has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            PrettyPageHandler.prototype.handle = function (next) {
            
                var helper = new TemplateHelper();
            
                var templateFile = this.__getResource("views/layout.ejs");
            Severity: Minor
            Found in handler/PrettyPageHandler.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language