radgrad/radgrad2

View on GitHub

Showing 211 of 211 total issues

Avoid too many return statements within this function.
Open

      return s;
Severity: Major
Found in archive/redux/admin/data-model/reducers.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          return s;
    Severity: Major
    Found in archive/redux/shared/cardExplorer/reducers.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return s;
      Severity: Major
      Found in archive/redux/admin/data-model/reducers.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return s;
        Severity: Major
        Found in archive/redux/shared/cardExplorer/reducers.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return s;
          Severity: Major
          Found in archive/redux/admin/data-model/reducers.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return s;
            Severity: Major
            Found in archive/redux/admin/data-model/reducers.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return s;
              Severity: Major
              Found in archive/redux/shared/cardExplorer/reducers.ts - About 30 mins to fix

                Function OpportunityInformationItem has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const OpportunityInformationItem: React.FC<OpportunityItemWidgetProps> = ({
                  informationConfiguration,
                  opportunity,
                }) => {
                  const match = useRouteMatch();
                Severity: Minor
                Found in archive/issue-399/OpportunityInformationItem.tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function findDoc has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  public findDoc(name: string | { [key: string]: unknown } | { name } | { _id: string; } | { username: string; }) {
                    if (_.isNull(name) || _.isUndefined(name)) {
                      throw new Meteor.Error(`${name} is not a defined ${this.type}`);
                    }
                    const doc = (
                Severity: Minor
                Found in app/imports/api/course/CourseCollection.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function updateState has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  public updateState(): void {
                    // console.log(this.profile.lastVisited);
                    const lastVisited = this.profile.lastVisited[PAGEIDS.VISIBILITY] || this.profile.lastVisited[PAGEIDS.STUDENT_VISIBILITY];
                    if (lastVisited) {
                      if (this.isSixMonthsOld(lastVisited)) {
                Severity: Minor
                Found in app/imports/ui/components/checklist/VisibilityChecklist.tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function AdminManageInternshipsPage has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const AdminManageInternshipsPage: React.FC = () => {
                  const [deleteWorking, setDeleteWorking] = useState(false);
                  const [uploadWorking, setUploadWorking] = useState(false);
                  const [defineWorking, setDefineWorking] = useState(false);
                  const [defineProgress, setDefineProgress] = useState(0);
                Severity: Minor
                Found in app/imports/ui/pages/admin/AdminManageInternshipsPage.tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function removeAllEntities has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                export const removeAllEntities = (): boolean => {
                  if (Meteor.isTest || Meteor.isAppTest) {
                    // assertIntegrity();  // this started failing after update to Meteor 1.6.1!
                    RadGrad.collections.forEach((collection) => {
                      if (collection.type !== 'AdminProfile') {
                Severity: Minor
                Found in app/imports/api/base/BaseUtilities.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function findAcademicTermSlug has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const findAcademicTermSlug = (starDataObject: StarDataObject): string => {
                  const academicTerm = starDataObject.semester;
                  if ((!_.isString(academicTerm)) || (academicTerm.length < 8)) {
                    throw new Meteor.Error(`Could not parse academic term data: ${JSON.stringify(starDataObject)}`);
                  }
                Severity: Minor
                Found in app/imports/api/star/StarProcessor.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function constructor has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  constructor(type: string, schema: any) {
                    this.type = type;
                    this.collectionName = `${type}Collection`;
                    this.collection = new Mongo.Collection(`${type}Collection`);
                    this.schema = schema.extend(new SimpleSchema({
                Severity: Minor
                Found in app/imports/api/base/BaseCollection.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  run(user: string) {
                    if (Meteor.isServer) {
                      StudentProfiles.assertValidRoleForMethod(this.userId);
                      const profile = Users.getProfile(user);
                      if (profile.role !== ROLE.STUDENT && profile.role !== ROLE.ALUMNI) {
                Severity: Minor
                Found in app/imports/api/user/StudentProfileCollection.methods.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function ExplorerCard has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const ExplorerCard: React.FC<ExplorerCardProps> = ({ item, type, inProfile }) => {
                  const match = useRouteMatch();
                  const itemName = (type === EXPLORER_TYPE.COURSES) ? Courses.getName(item._id) : docToName(item);
                  const itemShortDescription = docToShortDescription(item);
                  const slugName = itemToSlugName(item);
                Severity: Minor
                Found in app/imports/ui/components/shared/explorer/browser-view/ExplorerCard.tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  public update(docID: string, { name, description, interestType, retired, picture, keywords }: InterestUpdate) {
                    this.assertDefined(docID);
                    const updateData: { name?: string, description?: string, interestTypeID?: string, retired?: boolean, picture?:string } = {};
                    if (name) {
                      updateData.name = name;
                Severity: Minor
                Found in app/imports/api/interest/InterestCollection.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function descriptionPairs has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const descriptionPairs = (item: Review): DescriptionPair[] => {
                  let reviewee;
                  if (item.reviewType === ReviewTypes.COURSE) {
                    reviewee = Courses.findDoc(item.revieweeID);
                  } else if (item.reviewType === ReviewTypes.OPPORTUNITY) {
                Severity: Minor
                Found in app/imports/ui/pages/admin/AdminDataModelReviewsPage.tsx - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  run({ studentID }) {
                    if (Meteor.isServer) {
                      if (!this.userId) {
                        throw new Meteor.Error('unauthorized', 'You must be logged in to calculate Levels.');
                      } else if (!Roles.userIsInRole(this.userId, [ROLE.ADMIN, ROLE.ADVISOR])) {
                Severity: Minor
                Found in app/imports/api/level/LevelProcessor.methods.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  run(fixtureData) {
                    // console.log('loadFixtureMethod', fixtureData);
                    if (!this.userId) {
                      throw new Meteor.Error('unauthorized', 'You must be logged in to load a fixture.', '');
                    } else if (!Roles.userIsInRole(this.userId, [ROLE.ADMIN])) {
                Severity: Minor
                Found in app/imports/api/base/BaseCollection.methods.ts - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language