railpage/railpagecore

View on GitHub
lib/Assets/Asset.php

Summary

Maintainability
C
1 day
Test Coverage

Function load has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    private function load() {

        if (!$row = $this->db->fetchRow("SELECT * FROM asset WHERE id = ?", $this->id)) {
            return;
        }
Severity: Minor
Found in lib/Assets/Asset.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function load() {

        if (!$row = $this->db->fetchRow("SELECT * FROM asset WHERE id = ?", $this->id)) {
            return;
        }
Severity: Minor
Found in lib/Assets/Asset.php - About 1 hr to fix

    Method commit has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function commit() {
    
            $this->validate();
    
            $this->hash = md5($this->meta['url']);
    Severity: Minor
    Found in lib/Assets/Asset.php - About 1 hr to fix

      The method load() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          private function load() {
      
              if (!$row = $this->db->fetchRow("SELECT * FROM asset WHERE id = ?", $this->id)) {
                  return;
              }
      Severity: Minor
      Found in lib/Assets/Asset.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Avoid assigning values to variables in if clauses and the like (line '144', column '14').
      Open

          private function load() {
      
              if (!$row = $this->db->fetchRow("SELECT * FROM asset WHERE id = ?", $this->id)) {
                  return;
              }
      Severity: Minor
      Found in lib/Assets/Asset.php by phpmd

      IfStatementAssignment

      Since: 2.7.0

      Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($foo = 'bar') { // possible typo
                  // ...
              }
              if ($baz = 0) { // always false
                  // ...
              }
          }
      }

      Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

      Similar blocks of code found in 23 locations. Consider refactoring.
      Open

              $this->meta = json_decode($row['meta'], true);
      Severity: Major
      Found in lib/Assets/Asset.php and 22 other locations - About 45 mins to fix
      lib/Chronicle/Entry.php on lines 156..156
      lib/Events/Event.php on lines 207..207
      lib/Events/EventDate.php on lines 154..154
      lib/Gallery/Album.php on lines 136..136
      lib/Gallery/Image.php on lines 208..208
      lib/Ideas/Idea.php on lines 166..166
      lib/Images/Camera.php on lines 116..116
      lib/Images/Competition.php on lines 180..180
      lib/Images/Competition.php on lines 790..790
      lib/Locos/Date.php on lines 158..158
      lib/Locos/LocoClass.php on lines 417..417
      lib/News/Feed.php on lines 234..234
      lib/News/Feed.php on lines 235..235
      lib/Newsletters/Newsletter.php on lines 128..128
      lib/Newsletters/Newsletter.php on lines 129..129
      lib/Railcams/Storage.php on lines 201..201
      lib/Sightings/Sighting.php on lines 161..161
      lib/Sightings/Sighting.php on lines 162..162
      lib/Timetables/Train.php on lines 174..174
      lib/Users/Group.php on lines 168..168
      lib/Users/User.php on lines 1068..1068
      lib/SiteEvent.php on lines 135..135

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (empty( $this->namespace )) {
                  throw new Exception("Cannot validate changes to this asset - $this->namespace cannot be empty");
              }
      Severity: Minor
      Found in lib/Assets/Asset.php and 1 other location - About 45 mins to fix
      lib/Assets/Asset.php on lines 278..280

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if (empty( $this->namespace_key )) {
                  throw new Exception("Cannot validate changes to this asset - $this->namespace key cannot be empty");
              }
      Severity: Minor
      Found in lib/Assets/Asset.php and 1 other location - About 45 mins to fix
      lib/Assets/Asset.php on lines 274..276

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              $this->url = new Url("/assets?id=" . $this->id);
      Severity: Major
      Found in lib/Assets/Asset.php and 3 other locations - About 35 mins to fix
      lib/Locos/Liveries/Livery.php on lines 163..163
      lib/Locos/Liveries/Livery.php on lines 200..200
      lib/Sightings/Sighting.php on lines 167..167

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 22.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if (is_string($val)) {
                      $this->meta[$key] = trim($val);
                  }
      Severity: Minor
      Found in lib/Assets/Asset.php and 1 other location - About 30 mins to fix
      lib/News/Feed.php on lines 256..258

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 21.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status