railpage/railpagecore

View on GitHub
lib/BanControl/LookupUtility.php

Summary

Maintainability
F
3 days
Test Coverage

Function lookup has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    public static function lookup($type, $id, $activeOnly) {
        
        $Database = (new AppCore)->getDatabaseConnection(); 
        
        if ($type == "ip") {
Severity: Minor
Found in lib/BanControl/LookupUtility.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function recent has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public static function recent($activeOnly = null) {
        
        $Database = (new AppCore)->getDatabaseConnection(); 
        
        $query = "SELECT b.id, b.user_id, un.username AS username, b.ban_active, b.ban_time, b.ban_expire, b.ban_reason, b.banned_by, u.username AS banned_by_username 
Severity: Minor
Found in lib/BanControl/LookupUtility.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method recent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function recent($activeOnly = null) {
        
        $Database = (new AppCore)->getDatabaseConnection(); 
        
        $query = "SELECT b.id, b.user_id, un.username AS username, b.ban_active, b.ban_time, b.ban_expire, b.ban_reason, b.banned_by, u.username AS banned_by_username 
Severity: Minor
Found in lib/BanControl/LookupUtility.php - About 1 hr to fix

    Method lookup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function lookup($type, $id, $activeOnly) {
            
            $Database = (new AppCore)->getDatabaseConnection(); 
            
            if ($type == "ip") {
    Severity: Minor
    Found in lib/BanControl/LookupUtility.php - About 1 hr to fix

      The method lookup() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
      Open

          public static function lookup($type, $id, $activeOnly) {
              
              $Database = (new AppCore)->getDatabaseConnection(); 
              
              if ($type == "ip") {
      Severity: Minor
      Found in lib/BanControl/LookupUtility.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  if ($activeOnly !== true || ($activeOnly === true && $row['ban_active'] == 1)) {
                      if (!$row['ban_time'] instanceof DateTime) {
                          $row['ban_time'] = new DateTime("@" . $row['ban_time']); 
                      }
                      
      Severity: Major
      Found in lib/BanControl/LookupUtility.php and 1 other location - About 1 day to fix
      lib/BanControl/LookupUtility.php on lines 47..67

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 190.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  if ($activeOnly === false || ($activeOnly === true && $row['ban_active'] == 1)) {
                      if (!$row['ban_time'] instanceof DateTime) {
                          $row['ban_time'] = new DateTime("@" . $row['ban_time']); 
                      }
                      
      Severity: Major
      Found in lib/BanControl/LookupUtility.php and 1 other location - About 1 day to fix
      lib/BanControl/LookupUtility.php on lines 95..115

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 190.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              $reversedIp = implode(".", array_reverse(explode(".", $ip)));
      Severity: Minor
      Found in lib/BanControl/LookupUtility.php and 1 other location - About 30 mins to fix
      lib/Users/User.php on lines 1579..1579

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 20.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function closing brace must go on the next line following the body; found 1 blank lines before brace
      Open

          }

      Function closing brace must go on the next line following the body; found 1 blank lines before brace
      Open

          }

      Function closing brace must go on the next line following the body; found 1 blank lines before brace
      Open

          }

      There are no issues that match your filters.

      Category
      Status