railpage/railpagecore

View on GitHub
lib/Chronicle/Chronicle.php

Summary

Maintainability
C
7 hrs
Test Coverage

Avoid assigning values to variables in if clauses and the like (line '105', column '13').
Open

    public function getEntriesForToday($limit = 100) {
        
        $Date = new DateTime;
        
        $cachekey = sprintf("railpage:chronicle.date=%s;limit=%d", $Date->getTimestamp(), $limit); 
Severity: Minor
Found in lib/Chronicle/Chronicle.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function getLatestAdditions() {
        $query = "SELECT id FROM chronicle_item WHERE status = ? ORDER BY id DESC LIMIT 0, 10";
        
        foreach ($this->db->fetchAll($query, Entry::STATUS_ACTIVE) as $row) {
            yield new Entry($row['id']);
Severity: Major
Found in lib/Chronicle/Chronicle.php and 2 other locations - About 1 hr to fix
lib/Events/Events.php on lines 156..162
lib/Events/Events.php on lines 170..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 47.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 23 locations. Consider refactoring.
Open

        $this->url->year = sprintf("%s?mode=year", $this->url->url);
Severity: Major
Found in lib/Chronicle/Chronicle.php and 22 other locations - About 45 mins to fix
lib/Chronicle/Chronicle.php on lines 42..42
lib/Chronicle/Chronicle.php on lines 44..44
lib/Chronicle/Chronicle.php on lines 45..45
lib/Chronicle/Chronicle.php on lines 46..46
lib/Images/Competition.php on lines 150..150
lib/Jobs/Job.php on lines 196..196
lib/Locos/Locomotive.php on lines 432..432
lib/Locos/Locomotive.php on lines 433..433
lib/Railcams/Camera.php on lines 258..258
lib/Railcams/Camera.php on lines 259..259
lib/Railcams/Camera.php on lines 261..261
lib/Railcams/Camera.php on lines 262..262
lib/Railcams/Camera.php on lines 263..263
lib/Railcams/Camera.php on lines 264..264
lib/Railcams/Camera.php on lines 266..266
lib/Timetables/Point.php on lines 115..115
lib/Timetables/Timetables.php on lines 41..41
lib/Timetables/Timetables.php on lines 42..42
lib/Timetables/Timetables.php on lines 43..43
lib/Timetables/Train.php on lines 183..183
lib/Users/Group.php on lines 222..222
lib/Users/Group.php on lines 223..223

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 23 locations. Consider refactoring.
Open

        $this->url->thismonth = sprintf("%s?mode=thismonth", $this->url->url);
Severity: Major
Found in lib/Chronicle/Chronicle.php and 22 other locations - About 45 mins to fix
lib/Chronicle/Chronicle.php on lines 42..42
lib/Chronicle/Chronicle.php on lines 43..43
lib/Chronicle/Chronicle.php on lines 44..44
lib/Chronicle/Chronicle.php on lines 45..45
lib/Images/Competition.php on lines 150..150
lib/Jobs/Job.php on lines 196..196
lib/Locos/Locomotive.php on lines 432..432
lib/Locos/Locomotive.php on lines 433..433
lib/Railcams/Camera.php on lines 258..258
lib/Railcams/Camera.php on lines 259..259
lib/Railcams/Camera.php on lines 261..261
lib/Railcams/Camera.php on lines 262..262
lib/Railcams/Camera.php on lines 263..263
lib/Railcams/Camera.php on lines 264..264
lib/Railcams/Camera.php on lines 266..266
lib/Timetables/Point.php on lines 115..115
lib/Timetables/Timetables.php on lines 41..41
lib/Timetables/Timetables.php on lines 42..42
lib/Timetables/Timetables.php on lines 43..43
lib/Timetables/Train.php on lines 183..183
lib/Users/Group.php on lines 222..222
lib/Users/Group.php on lines 223..223

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 23 locations. Consider refactoring.
Open

        $this->url->thisweek = sprintf("%s?mode=thisweek", $this->url->url);
Severity: Major
Found in lib/Chronicle/Chronicle.php and 22 other locations - About 45 mins to fix
lib/Chronicle/Chronicle.php on lines 42..42
lib/Chronicle/Chronicle.php on lines 43..43
lib/Chronicle/Chronicle.php on lines 44..44
lib/Chronicle/Chronicle.php on lines 46..46
lib/Images/Competition.php on lines 150..150
lib/Jobs/Job.php on lines 196..196
lib/Locos/Locomotive.php on lines 432..432
lib/Locos/Locomotive.php on lines 433..433
lib/Railcams/Camera.php on lines 258..258
lib/Railcams/Camera.php on lines 259..259
lib/Railcams/Camera.php on lines 261..261
lib/Railcams/Camera.php on lines 262..262
lib/Railcams/Camera.php on lines 263..263
lib/Railcams/Camera.php on lines 264..264
lib/Railcams/Camera.php on lines 266..266
lib/Timetables/Point.php on lines 115..115
lib/Timetables/Timetables.php on lines 41..41
lib/Timetables/Timetables.php on lines 42..42
lib/Timetables/Timetables.php on lines 43..43
lib/Timetables/Train.php on lines 183..183
lib/Users/Group.php on lines 222..222
lib/Users/Group.php on lines 223..223

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 23 locations. Consider refactoring.
Open

        $this->url->newest = sprintf("%s?mode=newest", $this->url->url);
Severity: Major
Found in lib/Chronicle/Chronicle.php and 22 other locations - About 45 mins to fix
lib/Chronicle/Chronicle.php on lines 43..43
lib/Chronicle/Chronicle.php on lines 44..44
lib/Chronicle/Chronicle.php on lines 45..45
lib/Chronicle/Chronicle.php on lines 46..46
lib/Images/Competition.php on lines 150..150
lib/Jobs/Job.php on lines 196..196
lib/Locos/Locomotive.php on lines 432..432
lib/Locos/Locomotive.php on lines 433..433
lib/Railcams/Camera.php on lines 258..258
lib/Railcams/Camera.php on lines 259..259
lib/Railcams/Camera.php on lines 261..261
lib/Railcams/Camera.php on lines 262..262
lib/Railcams/Camera.php on lines 263..263
lib/Railcams/Camera.php on lines 264..264
lib/Railcams/Camera.php on lines 266..266
lib/Timetables/Point.php on lines 115..115
lib/Timetables/Timetables.php on lines 41..41
lib/Timetables/Timetables.php on lines 42..42
lib/Timetables/Timetables.php on lines 43..43
lib/Timetables/Train.php on lines 183..183
lib/Users/Group.php on lines 222..222
lib/Users/Group.php on lines 223..223

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 23 locations. Consider refactoring.
Open

        $this->url->today = sprintf("%s?mode=today", $this->url->url);
Severity: Major
Found in lib/Chronicle/Chronicle.php and 22 other locations - About 45 mins to fix
lib/Chronicle/Chronicle.php on lines 42..42
lib/Chronicle/Chronicle.php on lines 43..43
lib/Chronicle/Chronicle.php on lines 45..45
lib/Chronicle/Chronicle.php on lines 46..46
lib/Images/Competition.php on lines 150..150
lib/Jobs/Job.php on lines 196..196
lib/Locos/Locomotive.php on lines 432..432
lib/Locos/Locomotive.php on lines 433..433
lib/Railcams/Camera.php on lines 258..258
lib/Railcams/Camera.php on lines 259..259
lib/Railcams/Camera.php on lines 261..261
lib/Railcams/Camera.php on lines 262..262
lib/Railcams/Camera.php on lines 263..263
lib/Railcams/Camera.php on lines 264..264
lib/Railcams/Camera.php on lines 266..266
lib/Timetables/Point.php on lines 115..115
lib/Timetables/Timetables.php on lines 41..41
lib/Timetables/Timetables.php on lines 42..42
lib/Timetables/Timetables.php on lines 43..43
lib/Timetables/Train.php on lines 183..183
lib/Users/Group.php on lines 222..222
lib/Users/Group.php on lines 223..223

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 22 locations. Consider refactoring.
Open

        $this->Memcached->save($cachekey, $result, strtotime("+24 hours"));
Severity: Major
Found in lib/Chronicle/Chronicle.php and 21 other locations - About 40 mins to fix
lib/Config/Base.php on lines 40..40
lib/Config/Base.php on lines 111..111
lib/Downloads/Download.php on lines 530..530
lib/Glossary/Glossary.php on lines 107..107
lib/Images/Images.php on lines 110..110
lib/Links/Links.php on lines 94..94
lib/Links/Links.php on lines 129..129
lib/Locations/Country.php on lines 179..179
lib/Locations/Country.php on lines 180..180
lib/Locations/Location.php on lines 811..811
lib/Locations/Locations.php on lines 76..76
lib/Locations/Locations.php on lines 127..127
lib/Locations/Locations.php on lines 161..161
lib/Locations/Locations.php on lines 474..474
lib/Locos/Locomotive.php on lines 1227..1227
lib/Locos/Locomotive.php on lines 1538..1538
lib/Locos/Locos.php on lines 238..238
lib/PrivateMessages/Folder.php on lines 259..259
lib/Users/Base.php on lines 82..82
lib/Users/Timeline.php on lines 241..241
lib/Place.php on lines 600..600

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 24.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if (!$dateObject instanceof DateTime) {
            $dateObject = new DateTime;
        }
Severity: Major
Found in lib/Chronicle/Chronicle.php and 4 other locations - About 40 mins to fix
lib/Events/EventCategory.php on lines 182..184
lib/Events/Events.php on lines 76..78
lib/Organisations/Organisation.php on lines 421..423
lib/Users/Base.php on lines 149..151

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 23.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        if ($result = $this->Memcached->Fetch($cachekey)) {
            return $result;
        }
Severity: Major
Found in lib/Chronicle/Chronicle.php and 8 other locations - About 30 mins to fix
lib/Links/Links.php on lines 40..42
lib/Locations/Location.php on lines 722..724
lib/Locations/Locations.php on lines 99..101
lib/Locos/Locomotive.php on lines 1206..1208
lib/Locos/Locomotive.php on lines 1500..1502
lib/Users/Timeline.php on lines 209..211
lib/Place.php on lines 383..385
lib/Place.php on lines 482..484

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }
Severity: Minor
Found in lib/Chronicle/Chronicle.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }
Severity: Minor
Found in lib/Chronicle/Chronicle.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }
Severity: Minor
Found in lib/Chronicle/Chronicle.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }
Severity: Minor
Found in lib/Chronicle/Chronicle.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }
Severity: Minor
Found in lib/Chronicle/Chronicle.php by phpcodesniffer

There are no issues that match your filters.

Category
Status