railpage/railpagecore

View on GitHub
lib/Chronicle/EntryType.php

Summary

Maintainability
C
1 day
Test Coverage

Avoid assigning values to variables in if clauses and the like (line '88', column '13').
Open

    public function __construct($id = null) {
        
        parent::__construct(); 
        
        if (!filter_var($id, FILTER_VALIDATE_INT)) {
Severity: Minor
Found in lib/Chronicle/EntryType.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function commit() {
        $this->validate(); 
        
        $data = array(
            "grouping" => $this->group,
Severity: Major
Found in lib/Chronicle/EntryType.php and 1 other location - About 5 hrs to fix
lib/Ideas/Category.php on lines 162..186

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if ($row = $this->db->fetchRow($query, $this->id)) {
            $this->text = $row['text'];
            $this->group = $row['grouping'];
        }
Severity: Major
Found in lib/Chronicle/EntryType.php and 4 other locations - About 1 hr to fix
lib/Help/Category.php on lines 83..86
lib/Jobs/Classification.php on lines 86..89
lib/Jobs/Location.php on lines 86..89
lib/Railcams/Type.php on lines 78..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

        if (!filter_var($id, FILTER_VALIDATE_INT)) {
            return;
        }
Severity: Major
Found in lib/Chronicle/EntryType.php and 8 other locations - About 30 mins to fix
lib/Chronicle/Entry.php on lines 140..142
lib/Events/EventDate.php on lines 143..145
lib/Feedback/FeedbackItem.php on lines 120..122
lib/GTFS/StandardRoute.php on lines 68..70
lib/GTFS/StandardStop.php on lines 97..99
lib/Ideas/Ideas.php on lines 185..187
lib/Images/Camera.php on lines 98..100
lib/Users/Group.php on lines 127..129

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 21.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (empty($this->group)) {
            $this->group = self::GROUPING_OTHER;
        }
Severity: Minor
Found in lib/Chronicle/EntryType.php and 2 other locations - About 30 mins to fix
lib/Chronicle/Entry.php on lines 216..218
lib/Users/User.php on lines 1220..1222

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 21.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }
Severity: Minor
Found in lib/Chronicle/EntryType.php by phpcodesniffer

Blank line found at end of control structure
Open

            
Severity: Minor
Found in lib/Chronicle/EntryType.php by phpcodesniffer

There are no issues that match your filters.

Category
Status