railpage/railpagecore

View on GitHub
lib/Chronicle/Provider/Locos.php

Summary

Maintainability
A
1 hr
Test Coverage

Avoid unused parameters such as '$dateObject'.
Open

    public function getEventsForDate($dateObject) {
Severity: Minor
Found in lib/Chronicle/Provider/Locos.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$dateObject'.
Open

    public function getEventsForMonth($dateObject) {
Severity: Minor
Found in lib/Chronicle/Provider/Locos.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$id'.
Open

    public function getEvent($id) {
Severity: Minor
Found in lib/Chronicle/Provider/Locos.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$dateObject'.
Open

    public function getEventsForWeek($dateObject) {
Severity: Minor
Found in lib/Chronicle/Provider/Locos.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$dateObject'.
Open

    public function getEventsForYear($dateObject) {
Severity: Minor
Found in lib/Chronicle/Provider/Locos.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Similar blocks of code found in 10 locations. Consider refactoring.
Open

        if (!$dateTo instanceof DateTime) {
            throw new Exception("dateTo is not an instance of \DateTime"); 
        }
Severity: Major
Found in lib/Chronicle/Provider/Locos.php and 9 other locations - About 35 mins to fix
lib/Chronicle/Provider/Locos.php on lines 45..47
lib/Chronicle/Provider/Railcams.php on lines 49..51
lib/Chronicle/Provider/Railcams.php on lines 53..55
lib/Events/Event.php on lines 388..390
lib/Locos/Locos.php on lines 769..771
lib/Locos/Locos.php on lines 772..774
lib/Notifications/Notification.php on lines 304..306
lib/Railcams/Footage.php on lines 139..141
lib/Users/Group.php on lines 352..354

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 22.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

        if (!$dateFrom instanceof DateTime) {
            throw new Exception("dateFrom is not an instance of \DateTime"); 
        }
Severity: Major
Found in lib/Chronicle/Provider/Locos.php and 9 other locations - About 35 mins to fix
lib/Chronicle/Provider/Locos.php on lines 49..51
lib/Chronicle/Provider/Railcams.php on lines 49..51
lib/Chronicle/Provider/Railcams.php on lines 53..55
lib/Events/Event.php on lines 388..390
lib/Locos/Locos.php on lines 769..771
lib/Locos/Locos.php on lines 772..774
lib/Notifications/Notification.php on lines 304..306
lib/Railcams/Footage.php on lines 139..141
lib/Users/Group.php on lines 352..354

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 22.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }

There are no issues that match your filters.

Category
Status