railpage/railpagecore

View on GitHub
lib/Config/Base.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method set has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function set($key = null, $value, $name) {
        
        if ($key == null) {
            throw new Exception("Cannot set config option - \$key not given"); 
        }
Severity: Minor
Found in lib/Config/Base.php - About 1 hr to fix

    Avoid assigning values to variables in if clauses and the like (line '38', column '18').
    Open

        public function get($key = null) {
            
            if ($key != null) {
                $cachekey = sprintf("railpage:config:%s", $key); 
                
    Severity: Minor
    Found in lib/Config/Base.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Avoid assigning values to variables in if clauses and the like (line '69', column '13').
    Open

        public static function getPhpBB($key = null) {
            
            $Memcached = AppCore::GetMemcached(); 
            
            $cachekey = sprintf("railpage:config_phpbb:%s", $key); 
    Severity: Minor
    Found in lib/Config/Base.php by phpmd

    IfStatementAssignment

    Since: 2.7.0

    Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($foo = 'bar') { // possible typo
                // ...
            }
            if ($baz = 0) { // always false
                // ...
            }
        }
    }

    Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

    Similar blocks of code found in 22 locations. Consider refactoring.
    Open

                    $this->Memcached->save($cachekey, $value, strtotime("+1 month")); 
    Severity: Major
    Found in lib/Config/Base.php and 21 other locations - About 40 mins to fix
    lib/Chronicle/Chronicle.php on lines 119..119
    lib/Config/Base.php on lines 111..111
    lib/Downloads/Download.php on lines 530..530
    lib/Glossary/Glossary.php on lines 107..107
    lib/Images/Images.php on lines 110..110
    lib/Links/Links.php on lines 94..94
    lib/Links/Links.php on lines 129..129
    lib/Locations/Country.php on lines 179..179
    lib/Locations/Country.php on lines 180..180
    lib/Locations/Location.php on lines 811..811
    lib/Locations/Locations.php on lines 76..76
    lib/Locations/Locations.php on lines 127..127
    lib/Locations/Locations.php on lines 161..161
    lib/Locations/Locations.php on lines 474..474
    lib/Locos/Locomotive.php on lines 1227..1227
    lib/Locos/Locomotive.php on lines 1538..1538
    lib/Locos/Locos.php on lines 238..238
    lib/PrivateMessages/Folder.php on lines 259..259
    lib/Users/Base.php on lines 82..82
    lib/Users/Timeline.php on lines 241..241
    lib/Place.php on lines 600..600

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 24.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 22 locations. Consider refactoring.
    Open

            $this->Memcached->save($cachekey, $value, strtotime("+1 month")); 
    Severity: Major
    Found in lib/Config/Base.php and 21 other locations - About 40 mins to fix
    lib/Chronicle/Chronicle.php on lines 119..119
    lib/Config/Base.php on lines 40..40
    lib/Downloads/Download.php on lines 530..530
    lib/Glossary/Glossary.php on lines 107..107
    lib/Images/Images.php on lines 110..110
    lib/Links/Links.php on lines 94..94
    lib/Links/Links.php on lines 129..129
    lib/Locations/Country.php on lines 179..179
    lib/Locations/Country.php on lines 180..180
    lib/Locations/Location.php on lines 811..811
    lib/Locations/Locations.php on lines 76..76
    lib/Locations/Locations.php on lines 127..127
    lib/Locations/Locations.php on lines 161..161
    lib/Locations/Locations.php on lines 474..474
    lib/Locos/Locomotive.php on lines 1227..1227
    lib/Locos/Locomotive.php on lines 1538..1538
    lib/Locos/Locos.php on lines 238..238
    lib/PrivateMessages/Folder.php on lines 259..259
    lib/Users/Base.php on lines 82..82
    lib/Users/Timeline.php on lines 241..241
    lib/Place.php on lines 600..600

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 24.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

        }
    Severity: Minor
    Found in lib/Config/Base.php by phpcodesniffer

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

        }
    Severity: Minor
    Found in lib/Config/Base.php by phpcodesniffer

    Function closing brace must go on the next line following the body; found 1 blank lines before brace
    Open

        }
    Severity: Minor
    Found in lib/Config/Base.php by phpcodesniffer

    Arguments with default values must be at the end of the argument list
    Open

        public function set($key = null, $value, $name) {
    Severity: Minor
    Found in lib/Config/Base.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status