railpage/railpagecore

View on GitHub
lib/Downloads/Category.php

Summary

Maintainability
C
7 hrs
Test Coverage

Missing class import via use statement (line '91', column '23').
Open

            throw new \Exception("Cannot fetch category - no category ID provided"); 
Severity: Minor
Found in lib/Downloads/Category.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if (filter_var($this->id, FILTER_VALIDATE_INT)) {
            $where = array(
                "category_id = ?" => $this->id
            );
            
Severity: Major
Found in lib/Downloads/Category.php and 4 other locations - About 2 hrs to fix
lib/Gallery/Album.php on lines 494..497
lib/Images/Camera.php on lines 192..196
lib/Images/Collection.php on lines 219..222
lib/Images/Competition.php on lines 321..327

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

        if (!filter_var($this->id, FILTER_VALIDATE_INT)) {
            $this->db->insert("download_categories", $data);
            $this->id = $this->db->lastInsertId();
        }
Severity: Major
Found in lib/Downloads/Category.php and 4 other locations - About 1 hr to fix
lib/Gallery/Album.php on lines 500..503
lib/Images/Camera.php on lines 198..201
lib/Images/Collection.php on lines 224..227
lib/Images/Competition.php on lines 329..332

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 50.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

        foreach (func_get_args() as $arg) {
            if (filter_var($arg, FILTER_VALIDATE_INT)) {
                $this->id = $arg;
            }
        }
Severity: Major
Found in lib/Downloads/Category.php and 2 other locations - About 1 hr to fix
lib/Downloads/Download.php on lines 171..175
lib/SiteMessage/SiteMessage.php on lines 40..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 37.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

        $this->url = new Url(sprintf("/downloads?mode=category&id=%d", $this->id));
Severity: Major
Found in lib/Downloads/Category.php and 9 other locations - About 55 mins to fix
lib/Content/Page.php on lines 154..154
lib/Downloads/Category.php on lines 183..183
lib/Feedback/FeedbackItem.php on lines 143..143
lib/Forums/Thread.php on lines 236..236
lib/Forums/Thread.php on lines 358..358
lib/Images/Camera.php on lines 130..130
lib/Locos/Manufacturer.php on lines 114..114
lib/Locos/Manufacturer.php on lines 143..143
lib/Locos/Operator.php on lines 113..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 10 locations. Consider refactoring.
Open

        $this->url = new Url(sprintf("/downloads?mode=category&id=%d", $this->id));
Severity: Major
Found in lib/Downloads/Category.php and 9 other locations - About 55 mins to fix
lib/Content/Page.php on lines 154..154
lib/Downloads/Category.php on lines 101..101
lib/Feedback/FeedbackItem.php on lines 143..143
lib/Forums/Thread.php on lines 236..236
lib/Forums/Thread.php on lines 358..358
lib/Images/Camera.php on lines 130..130
lib/Locos/Manufacturer.php on lines 114..114
lib/Locos/Manufacturer.php on lines 143..143
lib/Locos/Operator.php on lines 113..113

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

            "parentid" => ($this->Parent instanceof Category) ? $this->Parent->id : 0
Severity: Major
Found in lib/Downloads/Category.php and 3 other locations - About 35 mins to fix
lib/Downloads/Download.php on lines 332..332
lib/Forums/Forum.php on lines 329..329
lib/Locos/Utility/LocomotiveUtility.php on lines 92..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 22.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status