railpage/railpagecore

View on GitHub
lib/Formatting/EmoticonsRuleset.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function __construct has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct() {
        
        foreach (EmoticonsUtility::getEmoticons() as $key => $emoticons) {
            
            if (count($emoticons) === 1) {
Severity: Minor
Found in lib/Formatting/EmoticonsRuleset.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused local variables such as '$key'.
Open

        foreach (EmoticonsUtility::getEmoticons() as $key => $emoticons) {
Severity: Minor
Found in lib/Formatting/EmoticonsRuleset.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (isset($this->unicode_replace[$first])) {
                foreach ($emoticons as $icon) {
                    $this->unicode_replace[$icon] = $this->unicode_replace[$first]; 
                }
            }
Severity: Major
Found in lib/Formatting/EmoticonsRuleset.php and 1 other location - About 1 hr to fix
lib/Formatting/EmoticonsRuleset.php on lines 34..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (isset($this->shortcode_replace[$first])) {
                foreach ($emoticons as $icon) {
                    $this->shortcode_replace[$icon] = $this->shortcode_replace[$first]; 
                }
            }
Severity: Major
Found in lib/Formatting/EmoticonsRuleset.php and 1 other location - About 1 hr to fix
lib/Formatting/EmoticonsRuleset.php on lines 40..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 38.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Blank line found at start of control structure
Open

        foreach (EmoticonsUtility::getEmoticons() as $key => $emoticons) {

Blank line found at end of control structure
Open

            

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }

There are no issues that match your filters.

Category
Status