Sign upLogin

railpage/railpagecore

View on GitHub
Star
lib/Forums/Stats.php

Summary

Maintainability
F
6 days
Test Coverage

Method activeThreads has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function activeThreads($num_threads = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
Severity: Minor
Found in lib/Forums/Stats.php - About 1 hr to fix

    Method activeForums has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function activeForums($num_forums = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
    Severity: Minor
    Found in lib/Forums/Stats.php - About 1 hr to fix

      Function activeThreads has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function activeThreads($num_threads = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
      Severity: Minor
      Found in lib/Forums/Stats.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function activeForums has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function activeForums($num_forums = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
      Severity: Minor
      Found in lib/Forums/Stats.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function __construct() {
        parent::__construct();
        
        foreach (func_get_args() as $arg) {
            if (filter_var($arg, FILTER_VALIDATE_INT) || is_array($arg)) {
      Severity: Minor
      Found in lib/Forums/Stats.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function users has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function users($num_users = 5) {
        if ($this->db instanceof \sql_db) {
            $query = "SELECT user_id, username, uWheat, uChaff, (uWheat / uChaff * 100) AS rating FROM nuke_users WHERE user_active = 1 ORDER BY rating DESC LIMIT 0, ".$this->db->real_escape_string($num_users); 
            
            if ($rs = $this->db->query($query)) {
      Severity: Minor
      Found in lib/Forums/Stats.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function posts has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function posts($start = false, $end) {
        if (empty($end)) {
            $end = time(); 
        }
      Severity: Minor
      Found in lib/Forums/Stats.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                  return $result === false ? 0 : count($result);
      Severity: Major
      Found in lib/Forums/Stats.php - About 30 mins to fix

        The method posts has a boolean flag argument $start, which is a certain sign of a Single Responsibility Principle violation.
        Open

            public function posts($start = false, $end) {
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        BooleanArgumentFlag

        Since: 1.4.0

        A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

        Example

        class Foo {
    public function bar($flag = true) {
    }
}

        Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

        The method posts uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                    } else {
                throw new Exception($this->db->error); 
                return false;
            }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method activeForums uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $forum_list_exclusions = "";
        }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method activeForums uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                    } else {
                throw new Exception($this->db->error); 
                return false;
            }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '50', column '25').
        Open

            public function __construct() {
        parent::__construct();
        
        foreach (func_get_args() as $arg) {
            if (filter_var($arg, FILTER_VALIDATE_INT) || is_array($arg)) {
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid assigning values to variables in if clauses and the like (line '130', column '17').
        Open

            public function activeForums($num_forums = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        Avoid assigning values to variables in if clauses and the like (line '232', column '17').
        Open

            public function users($num_users = 5) {
        if ($this->db instanceof \sql_db) {
            $query = "SELECT user_id, username, uWheat, uChaff, (uWheat / uChaff * 100) AS rating FROM nuke_users WHERE user_active = 1 ORDER BY rating DESC LIMIT 0, ".$this->db->real_escape_string($num_users); 
            
            if ($rs = $this->db->query($query)) {
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        The method activeThreads uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                    } else {
                throw new Exception($this->db->error); 
                return false;
            }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '87', column '17').
        Open

            public function posts($start = false, $end) {
        if (empty($end)) {
            $end = time(); 
        }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        The method activeThreads uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $forum_list_exclusions = "";
        }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Avoid assigning values to variables in if clauses and the like (line '189', column '17').
        Open

            public function activeThreads($num_threads = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        IfStatementAssignment

        Since: 2.7.0

        Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

        Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

        The method activeThreads uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $query = "SELECT COUNT(*) AS num_posts, p.post_id, f.forum_id, f.forum_name, t.topic_id, t.topic_title 
                        FROM nuke_bbposts AS p 
                        LEFT JOIN nuke_bbforums AS f ON p.forum_id = f.forum_id 
                        LEFT JOIN nuke_bbtopics AS t ON t.topic_id = p.topic_id
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method activeForums uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $query = "SELECT COUNT(*) AS num_posts, p.post_id, f.forum_id, f.forum_name 
                        FROM nuke_bbposts AS p 
                        LEFT JOIN nuke_bbforums AS f ON p.forum_id = f.forum_id 
                        WHERE p.post_time >= ? ".$forum_list_exclusions."
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method users uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $query = "SELECT user_id, username, uWheat, uChaff, (uWheat / uChaff * 100) AS rating FROM nuke_users WHERE user_active = 1 ORDER BY rating DESC LIMIT 0, ?";
            
            $users = array();
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method posts uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                } else {
            $query = "SELECT post_id FROM nuke_bbposts WHERE post_time >= ? AND post_time <= ? AND forum_id NOT IN (31,37)";
            
            $result = $this->db->fetchAll($query, array($start, $end));
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        The method users uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
        Open

                    } else {
                throw new Exception($this->db->error); 
                return false;
            }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        ElseExpression

        Since: 1.4.0

        An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

        Example

        class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

        Source https://phpmd.org/rules/cleancode.html#elseexpression

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function activeThreads($num_threads = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
        Severity: Major
        Found in lib/Forums/Stats.php and 1 other location - About 1 day to fix
        lib/Forums/Stats.php on lines 110..158

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 275.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public function activeForums($num_forums = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
        Severity: Major
        Found in lib/Forums/Stats.php and 1 other location - About 1 day to fix
        lib/Forums/Stats.php on lines 168..218

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 275.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if ($rs = $this->db->query($query)) {
                $users = array(); 
                while ($row = $rs->fetch_assoc()) {
                    $users[$row['user_id']] = $row; 
                }
        Severity: Major
        Found in lib/Forums/Stats.php and 1 other location - About 3 hrs to fix
        lib/PrivateMessages/PrivateMessages.php on lines 92..102

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function getPostsByHour(DateTime $From, DateTime $To) {
        $query = "SELECT HOUR(FROM_UNIXTIME(post_time)) AS hour, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    GROUP BY HOUR(FROM_UNIXTIME(post_time))";
        Severity: Major
        Found in lib/Forums/Stats.php and 3 other locations - About 2 hrs to fix
        lib/Forums/Stats.php on lines 281..288
        lib/Forums/Stats.php on lines 298..306
        lib/Forums/Stats.php on lines 316..324

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function getPostsByDay(DateTime $From, DateTime $To) {
        $query = "SELECT DAY(FROM_UNIXTIME(post_time)) AS day, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    GROUP BY DAY(FROM_UNIXTIME(post_time))";
        Severity: Major
        Found in lib/Forums/Stats.php and 3 other locations - About 2 hrs to fix
        lib/Forums/Stats.php on lines 264..271
        lib/Forums/Stats.php on lines 298..306
        lib/Forums/Stats.php on lines 316..324

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function getPostsByHourAndDay(DateTime $From, DateTime $To) {
        $query = "SELECT DAY(FROM_UNIXTIME(post_time)) AS day, HOUR(FROM_UNIXTIME(post_time)) AS hour, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    AND poster_id NOT IN (305,23967)
        Severity: Major
        Found in lib/Forums/Stats.php and 3 other locations - About 2 hrs to fix
        lib/Forums/Stats.php on lines 264..271
        lib/Forums/Stats.php on lines 281..288
        lib/Forums/Stats.php on lines 316..324

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            public function getPostsByMonthAndYear(DateTime $From, DateTime $To) {
        $query = "SELECT YEAR(FROM_UNIXTIME(post_time)) AS year, MONTH(FROM_UNIXTIME(post_time)) AS month, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    AND poster_id NOT IN (305,23967)
        Severity: Major
        Found in lib/Forums/Stats.php and 3 other locations - About 2 hrs to fix
        lib/Forums/Stats.php on lines 264..271
        lib/Forums/Stats.php on lines 281..288
        lib/Forums/Stats.php on lines 298..306

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 58.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    $query = "SELECT post_id FROM nuke_bbposts WHERE post_time >= ".$this->db->real_escape_string($start)." AND post_time <= ".$this->db->real_escape_string($end) . " AND forum_id NOT IN (31,37)";
        Severity: Major
        Found in lib/Forums/Stats.php and 1 other location - About 1 hr to fix
        lib/SiteMessage/Message.php on lines 79..79

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 39.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    foreach ($this->db->fetchAll($query, $num_users) as $row) {
                $users[$row['user_id']] = $row; 
            }
        Severity: Major
        Found in lib/Forums/Stats.php and 1 other location - About 1 hr to fix
        lib/Locos/Locos.php on lines 958..960

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    $result = $this->db->fetchAll($query, array($start, $end));
        Severity: Major
        Found in lib/Forums/Stats.php and 3 other locations - About 45 mins to fix
        lib/Forums/Thread.php on lines 223..223
        lib/Locations/Locations.php on lines 190..190
        lib/Sightings/Sightings.php on lines 41..41

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 25.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid excessively long variable names like $forum_list_exclusions. Keep variable name length under 20.
        Open

                    $forum_list_exclusions = "AND p.forum_id IN (".implode(",", $this->forum_list).")";
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        Avoid excessively long variable names like $forum_list_exclusions. Keep variable name length under 20.
        Open

                    $forum_list_exclusions = "AND p.forum_id IN (".implode(",", $this->forum_list).")";
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        LongVariable

        Since: 0.2

        Detects when a field, formal or local variable is declared with a long name.

        Example

        class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

        Source https://phpmd.org/rules/naming.html#longvariable

        The parameter $num_threads is not named in camelCase.
        Open

            public function activeThreads($num_threads = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $From is not named in camelCase.
        Open

            public function getPostsByHourAndDay(DateTime $From, DateTime $To) {
        $query = "SELECT DAY(FROM_UNIXTIME(post_time)) AS day, HOUR(FROM_UNIXTIME(post_time)) AS hour, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    AND poster_id NOT IN (305,23967)
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $From is not named in camelCase.
        Open

            public function getPostsByMonthAndYear(DateTime $From, DateTime $To) {
        $query = "SELECT YEAR(FROM_UNIXTIME(post_time)) AS year, MONTH(FROM_UNIXTIME(post_time)) AS month, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    AND poster_id NOT IN (305,23967)
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $num_users is not named in camelCase.
        Open

            public function users($num_users = 5) {
        if ($this->db instanceof \sql_db) {
            $query = "SELECT user_id, username, uWheat, uChaff, (uWheat / uChaff * 100) AS rating FROM nuke_users WHERE user_active = 1 ORDER BY rating DESC LIMIT 0, ".$this->db->real_escape_string($num_users); 
            
            if ($rs = $this->db->query($query)) {
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $From is not named in camelCase.
        Open

            public function getPostsByDay(DateTime $From, DateTime $To) {
        $query = "SELECT DAY(FROM_UNIXTIME(post_time)) AS day, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    GROUP BY DAY(FROM_UNIXTIME(post_time))";
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $To is not named in camelCase.
        Open

            public function getPostsByDay(DateTime $From, DateTime $To) {
        $query = "SELECT DAY(FROM_UNIXTIME(post_time)) AS day, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    GROUP BY DAY(FROM_UNIXTIME(post_time))";
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $To is not named in camelCase.
        Open

            public function getPostsByHourAndDay(DateTime $From, DateTime $To) {
        $query = "SELECT DAY(FROM_UNIXTIME(post_time)) AS day, HOUR(FROM_UNIXTIME(post_time)) AS hour, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    AND poster_id NOT IN (305,23967)
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $From is not named in camelCase.
        Open

            public function getPostsByHour(DateTime $From, DateTime $To) {
        $query = "SELECT HOUR(FROM_UNIXTIME(post_time)) AS hour, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    GROUP BY HOUR(FROM_UNIXTIME(post_time))";
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $To is not named in camelCase.
        Open

            public function getPostsByHour(DateTime $From, DateTime $To) {
        $query = "SELECT HOUR(FROM_UNIXTIME(post_time)) AS hour, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    GROUP BY HOUR(FROM_UNIXTIME(post_time))";
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $To is not named in camelCase.
        Open

            public function getPostsByMonthAndYear(DateTime $From, DateTime $To) {
        $query = "SELECT YEAR(FROM_UNIXTIME(post_time)) AS year, MONTH(FROM_UNIXTIME(post_time)) AS month, count(*) AS count
                    FROM nuke_bbposts 
                    WHERE post_time BETWEEN UNIX_TIMESTAMP(?) AND UNIX_TIMESTAMP(?)
                    AND poster_id NOT IN (305,23967)
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        The parameter $num_forums is not named in camelCase.
        Open

            public function activeForums($num_forums = 1, $age) {
        if (empty($age)) {
            $age = strtotime("30 days ago"); 
        }
        Severity: Minor
        Found in lib/Forums/Stats.php by phpmd

        CamelCaseParameterName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name parameters.

        Example

        class ClassName {
    public function doSomething($user_name) {
    }
}

        Source

        Arguments with default values must be at the end of the argument list
        Open

            public function activeForums($num_forums = 1, $age) {
        Severity: Minor
        Found in lib/Forums/Stats.php by phpcodesniffer

        Arguments with default values must be at the end of the argument list
        Open

            public function activeThreads($num_threads = 1, $age) {
        Severity: Minor
        Found in lib/Forums/Stats.php by phpcodesniffer

        Arguments with default values must be at the end of the argument list
        Open

            public function posts($start = false, $end) {
        Severity: Minor
        Found in lib/Forums/Stats.php by phpcodesniffer

        There are no issues that match your filters.

        Category
        Status