File `Location.php` has 417 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
    /**
     * Locations module 
     * @since Version 3.0
     * @package Railpage

Found in lib/Locations/Location.php - About 6 hrs to fix

The class Location has an overall complexity of 78 which is very high. The configured complexity threshold is 50.
Open

    class Location extends Locations {
        
        /**
         * Registry cache key
         * @since Version 3.9.1

Found in lib/Locations/Location.php by phpmd

Exclude checks
- Disable engine
- Disable check

Method `getPhotosForSite` has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function getPhotosForSite($num = 10, $start = 0) {
            
            $Place = new Place($this->lat, $this->lon); 
            
            return $Place->getPhotosFromSphinx($num);

Found in lib/Locations/Location.php - About 2 hrs to fix

Method `commit` has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public function commit() {
            
            /**
             * Fill in the gaps with the new Place object
             */

Found in lib/Locations/Location.php - About 2 hrs to fix

Method `load` has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private function load() {
            
            $this->mckey = sprintf("railpage:locations.location=%d", $this->id); 
            
            if (!$row = $this->Memcached->fetch($this->mckey)) {

Found in lib/Locations/Location.php - About 1 hr to fix

The class Location has 26 fields. Consider redesigning Location to keep the number of fields under 15.
Open

    class Location extends Locations {
        
        /**
         * Registry cache key
         * @since Version 3.9.1

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

TooManyFields

Since: 0.1

Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

Example

class Person {
   protected $one;
   private $two;
   private $three;
   [... many more fields ...]
}

Source https://phpmd.org/rules/codesize.html#toomanyfields

Method `validate` has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        private function validate() {
            
            if (!filter_var($this->lat, FILTER_VALIDATE_FLOAT)) {
                throw new Exception("Cannot validate location - no latitude value"); 
            }

Found in lib/Locations/Location.php - About 1 hr to fix

Function `validate` has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        private function validate() {
            
            if (!filter_var($this->lat, FILTER_VALIDATE_FLOAT)) {
                throw new Exception("Cannot validate location - no latitude value"); 
            }

Found in lib/Locations/Location.php - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method getPhotosForSite() has 105 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

        public function getPhotosForSite($num = 10, $start = 0) {
            
            $Place = new Place($this->lat, $this->lon); 
            
            return $Place->getPhotosFromSphinx($num);

Found in lib/Locations/Location.php by phpmd

Exclude checks
- Disable engine
- Disable check

The method geocode() has 104 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

        private function geocode() {
            
            if (!empty($this->region) && !empty($this->country) && !empty($this->locality)) {
                #return;
            }

Found in lib/Locations/Location.php by phpmd

Exclude checks
- Disable engine
- Disable check

The method validate() has an NPath complexity of 768. The configured NPath complexity threshold is 200.
Open

        private function validate() {
            
            if (!filter_var($this->lat, FILTER_VALIDATE_FLOAT)) {
                throw new Exception("Cannot validate location - no latitude value"); 
            }

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method validate() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

        private function validate() {
            
            if (!filter_var($this->lat, FILTER_VALIDATE_FLOAT)) {
                throw new Exception("Cannot validate location - no latitude value"); 
            }

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method load() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
Open

        private function load() {
            
            $this->mckey = sprintf("railpage:locations.location=%d", $this->id); 
            
            if (!$row = $this->Memcached->fetch($this->mckey)) {

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method recommend has a boolean flag argument $user_id, which is a certain sign of a Single Responsibility Principle violation.
Open

        public function recommend($user_id = false) {

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method doesUserLike has a boolean flag argument $user_id, which is a certain sign of a Single Responsibility Principle violation.
Open

        public function doesUserLike($user_id = false) {

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method __construct has a boolean flag argument $location_id, which is a certain sign of a Single Responsibility Principle violation.
Open

        public function __construct($location_id = false) {

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid assigning values to variables in if clauses and the like (line '313', column '18').
Open

        private function load() {
            
            $this->mckey = sprintf("railpage:locations.location=%d", $this->id); 
            
            if (!$row = $this->Memcached->fetch($this->mckey)) {

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '293', column '50').
Open

        public function __construct($location_id = false) {
            
            parent::__construct(); 
            
            if ($id = filter_var($location_id, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '722', column '17').
Open

        public function getPhotosForSite($num = 10, $start = 0) {
            
            $Place = new Place($this->lat, $this->lon); 
            
            return $Place->getPhotosFromSphinx($num);

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '290', column '17').
Open

        public function __construct($location_id = false) {
            
            parent::__construct(); 
            
            if ($id = filter_var($location_id, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

The method commit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $this->db->insert("location", $data);
                $this->id = $this->db->lastInsertId();
                
                $this->Memcached->delete("railpage:locations.newest");

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid assigning values to variables in if clauses and the like (line '835', column '17').
Open

        public function doesUserLike($user_id = false) {
            
            if ($user_id instanceof User) {
                $user_id = $user_id->id;
            }

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid unused local variables such as '$row'.
Open

            if ($row = $this->db->fetchRow($query, array($this->id, $user_id))) {

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

Similar blocks of code found in 4 locations. Consider refactoring.
Open

        private function createSlug() {
            
            $proposal = ContentUtility::generateUrlSlug($this->name);
            
            $result = $this->db->fetchAll("SELECT id FROM location WHERE slug = ?", $proposal);

Found in lib/Locations/Location.php and 3 other locations - About 3 hrs to fix

Read up
Read up

lib/Help/Category.php on lines 140..151

lib/Ideas/Category.php on lines 142..154

lib/Locos/LocoClass.php on lines 783..794

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 73.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 31.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 26.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 24.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 23.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 23.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 22.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 21.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 21.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 21.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 20.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $location_id is not named in camelCase.
Open

        public function __construct($location_id = false) {
            
            parent::__construct(); 
            
            if ($id = filter_var($location_id, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The parameter $user_id is not named in camelCase.
Open

        public function doesUserLike($user_id = false) {
            
            if ($user_id instanceof User) {
                $user_id = $user_id->id;
            }

Found in lib/Locations/Location.php by phpmd

Read up
Read up
Exclude checks
- Disable engine
- Disable check

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $locality;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $date_modified;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $username;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!empty($this->region) && !empty($this->country) && !empty($this->locality)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 12 spaces, found 16
Open

                if (!empty($Place->Region->name)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty($this->id)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function getPhotosForSite($num = 10, $start = 0) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if ($row = $this->db->fetchRow($query, array($this->id, $user_id))) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $traffic;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $amenities;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty(filter_var($this->desc, FILTER_SANITIZE_STRING))) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!filter_var($this->zoom, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $country;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        private function geocode() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $active;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $id;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if ($id != $this->geoplace_id) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function getDates() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $environment;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty(filter_var($this->name, FILTER_SANITIZE_STRING))) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $Region;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty($this->region)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!empty($this->lat) && !empty($this->lon)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $name;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!filter_var($this->topicid, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $zoom;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $user_id;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $directions_driving;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $url;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!isset($row) || !is_array($row) || count($row) === 0 || !filter_var($row['id'], FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 0 spaces, found 4
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty($this->region) || empty($this->country)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!filter_var($user_id, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function reject() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function getContributors() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $lon;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $likes;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (isset($row)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 0 spaces, found 4
Open

    class Location extends Locations {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $lat;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if ($id = filter_var($location_id, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            } elseif (is_string($location_id) && $id = filter_var($location_id, FILTER_SANITIZE_STRING)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        private function load() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            foreach ($nulls as $var) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (filter_var($this->id, FILTER_VALIDATE_INT) && $this->id > 0) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if ($result = $this->Memcached->fetch($cachekey)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function approve() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty($this->id)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $topicid;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 12 spaces, found 16
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!$this->id || !$this->db) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $date_added;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 12 spaces, found 16
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty($this->slug)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function __construct($location_id = false) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function commit() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            foreach ($this->db->fetchAll($query, $params) as $data) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!filter_var($user_id, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $desc;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty($this->slug) && filter_var($this->id, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        private function validate() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 12 spaces, found 16
Open

                if (is_null($this->$var)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty($this->region)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 12 spaces, found 16
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function __toString() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $slug;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if ($this->geoplace_id == 0) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function doesUserLike($user_id = false) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $region;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        private function createSlug() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!filter_var($this->lat, FILTER_VALIDATE_FLOAT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $directions_parking;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 12 spaces, found 16
Open

                if (!empty($Place->Country->code)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        private $geoplace_id;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!$row = $this->Memcached->fetch($this->mckey)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 12 spaces, found 16
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (count($result)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            } else {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!filter_var($this->lon, FILTER_VALIDATE_FLOAT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if ($user_id instanceof User) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public $directions_pt;

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 12 spaces, found 16
Open

                if (filter_var($this->id, FILTER_VALIDATE_INT)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!filter_var($this->active)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if ($this->doesUserLike($user_id)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            foreach ($this->db->fetchAll($query, array("locations", "id", $this->id, $this->user_id)) as $row) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if ($user_id instanceof User) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty($this->region) || empty($this->country)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        private function updateGeoplace() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function recommend($user_id = false) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (empty($this->id)) {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function getArray() {

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 8 spaces, found 12
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

Line indented incorrectly; expected 4 spaces, found 8
Open

Found in lib/Locations/Location.php by phpcodesniffer

Exclude checks
- Disable engine
- Disable check

railpage/railpagecore

Summary

Maintainability

Test Coverage

File Location.php has 417 lines of code (exceeds 250 allowed). Consider refactoring. Open

The class Location has an overall complexity of 78 which is very high. The configured complexity threshold is 50. Open

Method getPhotosForSite has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open

Method commit has 72 lines of code (exceeds 25 allowed). Consider refactoring. Open

Method load has 48 lines of code (exceeds 25 allowed). Consider refactoring. Open

The class Location has 26 fields. Consider redesigning Location to keep the number of fields under 15. Open

TooManyFields

Since: 0.1

Example

Source https://phpmd.org/rules/codesize.html#toomanyfields

Method validate has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open

Function validate has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Function commit has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Function load has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

Function geocode has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open

Cognitive Complexity

A method's cognitive complexity is based on a few simple rules:

Further reading

The method load() has an NPath complexity of 720. The configured NPath complexity threshold is 200. Open

NPathComplexity

Since: 0.1

Example

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method getPhotosForSite() has 105 lines of code. Current threshold is set to 100. Avoid really long methods. Open

The method geocode() has 104 lines of code. Current threshold is set to 100. Avoid really long methods. Open

The method validate() has an NPath complexity of 768. The configured NPath complexity threshold is 200. Open

NPathComplexity

Since: 0.1

Example

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method validate() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10. Open

CyclomaticComplexity

Since: 0.1

Example

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method load() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10. Open

CyclomaticComplexity

Since: 0.1

Example

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

The method recommend has a boolean flag argument $user_id, which is a certain sign of a Single Responsibility Principle violation. Open

BooleanArgumentFlag

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method doesUserLike has a boolean flag argument $user_id, which is a certain sign of a Single Responsibility Principle violation. Open

BooleanArgumentFlag

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method __construct has a boolean flag argument $location_id, which is a certain sign of a Single Responsibility Principle violation. Open

BooleanArgumentFlag

Since: 1.4.0

Example

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Avoid assigning values to variables in if clauses and the like (line '313', column '18'). Open

IfStatementAssignment

Since: 2.7.0

Example

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '293', column '50'). Open

IfStatementAssignment

Since: 2.7.0

Example

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '722', column '17'). Open

IfStatementAssignment

File `Location.php` has 417 lines of code (exceeds 250 allowed). Consider refactoring.
Open

The class Location has an overall complexity of 78 which is very high. The configured complexity threshold is 50.
Open

Method `getPhotosForSite` has 74 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Method `commit` has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Method `load` has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

The class Location has 26 fields. Consider redesigning Location to keep the number of fields under 15.
Open

Method `validate` has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Function `validate` has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

Function `commit` has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

Function `load` has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

Function `geocode` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

The method load() has an NPath complexity of 720. The configured NPath complexity threshold is 200.
Open

The method getPhotosForSite() has 105 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

The method geocode() has 104 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

The method validate() has an NPath complexity of 768. The configured NPath complexity threshold is 200.
Open

The method validate() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

The method load() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
Open

The method recommend has a boolean flag argument $user_id, which is a certain sign of a Single Responsibility Principle violation.
Open

The method doesUserLike has a boolean flag argument $user_id, which is a certain sign of a Single Responsibility Principle violation.
Open

The method __construct has a boolean flag argument $location_id, which is a certain sign of a Single Responsibility Principle violation.
Open

Avoid assigning values to variables in if clauses and the like (line '313', column '18').
Open

Avoid assigning values to variables in if clauses and the like (line '293', column '50').
Open

Avoid assigning values to variables in if clauses and the like (line '722', column '17').
Open

Avoid assigning values to variables in if clauses and the like (line '290', column '17').
Open

The method commit uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

Avoid assigning values to variables in if clauses and the like (line '835', column '17').
Open

Avoid unused local variables such as '$row'.
Open

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Similar blocks of code found in 3 locations. Consider refactoring.
Open

Identical blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Similar blocks of code found in 25 locations. Consider refactoring.
Open

Similar blocks of code found in 25 locations. Consider refactoring.
Open

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Similar blocks of code found in 4 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open

Similar blocks of code found in 2 locations. Consider refactoring.
Open