Sign upLogin

railpage/railpagecore

View on GitHub
Star
lib/Organisations/OrganisationFromSlug.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid assigning values to variables in if clauses and the like (line '40', column '13').
Open

    public function __construct($slug = null) {
        
        if (is_null($slug)) {
            return;
        }
Severity: Minor
Found in lib/Organisations/OrganisationFromSlug.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

    }
Severity: Minor
Found in lib/Organisations/OrganisationFromSlug.php by phpcodesniffer

There must be one blank line after the namespace declaration
Open

namespace Railpage\Organisations;
Severity: Minor
Found in lib/Organisations/OrganisationFromSlug.php by phpcodesniffer

There are no issues that match your filters.

Category
Status