railpage/railpagecore

View on GitHub
lib/Reminders/Reminders.php

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public function getRemindersForUser() {
            
            if (!$this->User instanceof User) {
                throw new Exception("Can't find reminders because we don't know which user to look up");
            }
Severity: Major
Found in lib/Reminders/Reminders.php and 1 other location - About 3 hrs to fix
lib/Reminders/Reminders.php on lines 64..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        public function getPastRemindersForUser() {
            
            if (!$this->User instanceof User) {
                throw new Exception("Can't find reminders because we don't know which user to look up");
            }
Severity: Major
Found in lib/Reminders/Reminders.php and 1 other location - About 3 hrs to fix
lib/Reminders/Reminders.php on lines 43..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

        public function __construct() {
            
            parent::__construct();
            
            $this->Module = new Module("reminders");
Severity: Major
Found in lib/Reminders/Reminders.php and 5 other locations - About 50 mins to fix
lib/Gallery/Gallery.php on lines 30..36
lib/Help/Help.php on lines 27..33
lib/Ideas/Ideas.php on lines 78..84
lib/Images/Competitions.php on lines 91..94
lib/Jobs/Jobs.php on lines 35..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 27.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

        }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

        }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

        }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!$this->User instanceof User) {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function __construct() {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 0 spaces, found 4
Open

    class Reminders extends AppCore {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function getPastRemindersForUser() {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function getUpcoming() {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 0 spaces, found 4
Open

    }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            foreach ($this->db->fetchAll($query, array($this->User->id, date("Y-m-d"), 0)) as $row) {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            if (!$this->User instanceof User) {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        public function getRemindersForUser() {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 4 spaces, found 8
Open

        }
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            foreach ($this->db->fetchAll($query, array($this->User->id, date("Y-m-d"), 1)) as $row) {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

Line indented incorrectly; expected 8 spaces, found 12
Open

            foreach ($this->db->fetchAll($query, $params) as $row) {
Severity: Minor
Found in lib/Reminders/Reminders.php by phpcodesniffer

There are no issues that match your filters.

Category
Status