View on GitHub

Showing 2 of 2 total issues

Class Transaction has 29 methods (exceeds 20 allowed). Consider refactoring.

    class Transaction < Field
      self.tag = 61
      self.parser = %r{^(?<date>\d{6})(?<entry_date>\d{4})?(?<storno_flag>R?)(?<funds_code>[CD]{1})(?<currency_letter>[a-zA-Z])?(?<amount>\d{1,12},\d{0,2})(?<swift_code>(?:N|F).{3})(?<reference>NONREF|(.(?!\/\/)){,16}([^\/]){,1})((?:\/\/)(?<bank_reference>[^\n]{,16}))?((?:\n)(?<supplementary>.{,34}))?$}

      attr_accessor :details
Severity: Minor
Found in lib/cmxl/fields/transaction.rb - About 3 hrs to fix

    Method parse! has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.

        def parse!
          self.fields = []
          # split transactions, each transaction starts with a colon after a linebreak
          # do not remove line breaks within transaction lines as they are used to determine field details
    Severity: Minor
    Found in lib/cmxl/statement.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading