rakuten-ws/rws-ruby-sdk

View on GitHub
lib/rakuten_web_service/resource.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
98%

Do not prefix writer method names with set_.
Open

      def set_parser(&block)
Severity: Minor
Found in lib/rakuten_web_service/resource.rb by rubocop

This cop makes sure that accessor methods are named properly.

Example:

# bad
def set_attribute(value)
end

# good
def attribute=(value)
end

# bad
def get_attribute
end

# good
def attribute
end

Replace class var @@subclasses with a class instance var.
Confirmed

        @@subclasses ||= []
Severity: Minor
Found in lib/rakuten_web_service/resource.rb by rubocop

This cop checks for uses of class variables. Offenses are signaled only on assignment to class variables to reduce the number of offenses that would be reported.

Missing top-level class documentation comment.
Open

  class Resource
Severity: Minor
Found in lib/rakuten_web_service/resource.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Do not prefix writer method names with set_.
Open

      def set_resource_name(name)
Severity: Minor
Found in lib/rakuten_web_service/resource.rb by rubocop

This cop makes sure that accessor methods are named properly.

Example:

# bad
def set_attribute(value)
end

# good
def attribute=(value)
end

# bad
def get_attribute
end

# good
def attribute
end

There are no issues that match your filters.

Category
Status