Sign upLogin

rakuten-ws/rws-ruby-sdk

View on GitHub
Star
lib/rakuten_web_service/response.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Rename has_next_page? to next_page?.
Open

    def has_next_page?
Severity: Minor
Found in lib/rakuten_web_service/response.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Use ! instead of not.
Open

      page && (not first_page?)
Severity: Minor
Found in lib/rakuten_web_service/response.rb by rubocop

This cop checks for uses of the keyword not instead of !.

Example:

# bad - parentheses are required because of op precedence
x = (not something)

# good
x = !something

Use ! instead of not.
Open

      page && (not last_page?)
Severity: Minor
Found in lib/rakuten_web_service/response.rb by rubocop

This cop checks for uses of the keyword not instead of !.

Example:

# bad - parentheses are required because of op precedence
x = (not something)

# good
x = !something

Line is too long. [89/80]
Open

      RWS::GenreInformation.new(self['GenreInformation'][0], @resource_class.genre_class)
Severity: Minor
Found in lib/rakuten_web_service/response.rb by rubocop

Rename has_previous_page? to previous_page?.
Open

    def has_previous_page?
Severity: Minor
Found in lib/rakuten_web_service/response.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Missing top-level class documentation comment.
Open

  class Response
Severity: Minor
Found in lib/rakuten_web_service/response.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status