rapid7/metasploit-framework

View on GitHub

Showing 15,639 of 21,649 total issues

Avoid too many return statements within this method.
Open

                return "#{cred.public.nil? ? ' ' : cred.public.username}:#{cred.private.data}:#{cred.id}:"
Severity: Major
Found in lib/metasploit/framework/password_crackers/jtr/formatter.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                      return "#{cred.id}:#{cred.private.data}"
    Severity: Major
    Found in lib/metasploit/framework/password_crackers/hashcat/formatter.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                    return "Unsupported version ('#{@version}')"
      Severity: Major
      Found in lib/metasploit/framework/login_scanner/glassfish.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                      return ['bf']
        Severity: Major
        Found in lib/metasploit/framework/password_crackers/jtr/formatter.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                        return { status: LOGIN_STATUS::SUCCESSFUL, proof: res.body.to_s }
          Severity: Major
          Found in lib/metasploit/framework/login_scanner/syncovery_file_sync_backup.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                          return ['bsdi']
            Severity: Major
            Found in lib/metasploit/framework/password_crackers/jtr/formatter.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                return "#{cred.id}:#{Regexp.last_match(1).scan(/.{1,40}/m).join(':').downcase}"
              Severity: Major
              Found in lib/metasploit/framework/password_crackers/hashcat/formatter.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return { status: LOGIN_STATUS::SUCCESSFUL, proof: res.body }
                Severity: Major
                Found in lib/metasploit/framework/login_scanner/softing_sis.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return "#{cred.public.username}:#{cred.private.data}:::::#{cred.id}:"
                  Severity: Major
                  Found in lib/metasploit/framework/password_crackers/jtr/formatter.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return "$vnc$#{cred.private.data.start_with?('*') ? cred.private.data.upcase : "*#{cred.private.data.upcase}"}"
                    Severity: Major
                    Found in lib/metasploit/framework/password_crackers/jtr/formatter.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                        return "#{cred.id}:#{Regexp.last_match(1).upcase}"
                      Severity: Major
                      Found in lib/metasploit/framework/password_crackers/hashcat/formatter.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                          return "#{cred.id}:#{Regexp.last_match(1)}:#{cred.public.username}"
                        Severity: Major
                        Found in lib/metasploit/framework/password_crackers/hashcat/formatter.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                          return "#{cred.id}:#{cred.private.data}"
                          Severity: Major
                          Found in lib/metasploit/framework/password_crackers/hashcat/formatter.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return "Unable to connect to target"
                            Severity: Major
                            Found in lib/metasploit/framework/login_scanner/glassfish.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                                return "#{cred.public.username.upcase}:$dynamic_1506$#{Regexp.last_match(1)}:#{cred.id}:"
                              Severity: Major
                              Found in lib/metasploit/framework/password_crackers/jtr/formatter.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                  return "#{cred.public.username}:O$#{cred.public.username}##{cred.private.data}:#{cred.id}:"
                                Severity: Major
                                Found in lib/metasploit/framework/password_crackers/jtr/formatter.rb - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                                return ['pbkdf2,oracle12c']
                                  Severity: Major
                                  Found in lib/metasploit/framework/password_crackers/jtr/formatter.rb - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return [cred_type]
                                    Severity: Major
                                    Found in lib/metasploit/framework/password_crackers/jtr/formatter.rb - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                        return "#{cred.id}:#{hash}:#{salt}"
                                      Severity: Major
                                      Found in lib/metasploit/framework/password_crackers/hashcat/formatter.rb - About 30 mins to fix

                                        Method init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                        Open

                                           @SuppressWarnings("unchecked")
                                           public void init()
                                             {
                                            try
                                              {
                                        Severity: Minor
                                        Found in external/source/exploits/cve-2010-4452/AppletX.java - About 25 mins to fix

                                        Cognitive Complexity

                                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                        A method's cognitive complexity is based on a few simple rules:

                                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                        • Code is considered more complex for each "break in the linear flow of the code"
                                        • Code is considered more complex when "flow breaking structures are nested"

                                        Further reading

                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language