rapid7/metasploit-framework

View on GitHub
lib/msf/core/db_manager/import/metasploit_framework/xml.rb

Summary

Maintainability
F
5 days
Test Coverage

Method parse_host has a Cognitive Complexity of 103 (exceeds 5 allowed). Consider refactoring.
Open

  def parse_host(host, wspace, blacklist, allow_yaml, btag, args, &block)

    host_data = {}
    host_data[:task] = args[:task]
    host_data[:workspace] = wspace
Severity: Minor
Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_host has 210 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_host(host, wspace, blacklist, allow_yaml, btag, args, &block)

    host_data = {}
    host_data[:task] = args[:task]
    host_data[:workspace] = wspace
Severity: Major
Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 1 day to fix

    File xml.rb has 452 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'base64'
    module Msf::DBManager::Import::MetasploitFramework::XML
      #
      # CONSTANTS
      #
    Severity: Minor
    Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 6 hrs to fix

      Method import_msf_web_page_element has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def import_msf_web_page_element(element, options={}, &notifier)
          options.assert_valid_keys(:allow_yaml, :workspace)
      
          import_msf_web_element(element,
                                 :allow_yaml => options[:allow_yaml],
      Severity: Minor
      Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 1 hr to fix

        Method import_msf_xml has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def import_msf_xml(args={}, &block)
            data = args[:data]
            wspace = Msf::Util::DBManager.process_opts_workspace(args, framework).name
            args = args.clone()
            args.delete(:workspace)
        Severity: Minor
        Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 1 hr to fix

          Method import_msf_note_element has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def import_msf_note_element(note, allow_yaml, note_data={})
              note_data[:type] = nils_for_nulls(note.at("ntype").text.to_s.strip)
              note_data[:data] = nils_for_nulls(unserialize_object(note.at("data"), allow_yaml))
          
              if note.at("critical").text
          Severity: Minor
          Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method import_msf_web_vuln_element has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def import_msf_web_vuln_element(element, options={}, &notifier)
              options.assert_valid_keys(:allow_yaml, :workspace)
          
              import_msf_web_element(element,
                                     :allow_yaml => options[:allow_yaml],
          Severity: Minor
          Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 1 hr to fix

            Method parse_web_site has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def parse_web_site(web, wspace, allow_yaml, &block)
                # Import web sites
                info = {}
                info[:workspace] = wspace
            
            
            Severity: Minor
            Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method import_msf_xml has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def import_msf_xml(args={}, &block)
                data = args[:data]
                wspace = Msf::Util::DBManager.process_opts_workspace(args, framework).name
                args = args.clone()
                args.delete(:workspace)
            Severity: Minor
            Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method parse_host has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

              def parse_host(host, wspace, blacklist, allow_yaml, btag, args, &block)
            Severity: Major
            Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 50 mins to fix

              Method import_msf_web_page_element has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def import_msf_web_page_element(element, options={}, &notifier)
                  options.assert_valid_keys(:allow_yaml, :workspace)
              
                  import_msf_web_element(element,
                                         :allow_yaml => options[:allow_yaml],
              Severity: Minor
              Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  host.xpath("host_details/host_detail").each do |hdet|
                    hdet_data = {}
                    hdet.elements.each do |det|
                      next if ["id", "host-id"].include?(det.name)
                      if det.text
              Severity: Minor
              Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb and 1 other location - About 45 mins to fix
              lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 429..437

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 41.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    vuln.xpath("vuln_details/vuln_detail").each do |vdet|
                      vdet_data = {}
                      vdet.elements.each do |det|
                        next if ["id", "vuln-id"].include?(det.name)
                        if det.text
              Severity: Minor
              Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb and 1 other location - About 45 mins to fix
              lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 336..344

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 41.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 11 locations. Consider refactoring.
              Open

                def import_msf_file(args={})
                  filename = args[:filename]
              
                  data = ""
                  ::File.open(filename, 'rb') do |f|
              Severity: Major
              Found in lib/msf/core/db_manager/import/metasploit_framework/xml.rb and 10 other locations - About 20 mins to fix
              lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
              lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
              lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
              lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
              lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
              lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
              lib/msf/core/db_manager/import/nmap.rb on lines 241..248
              lib/msf/core/db_manager/import/qualys/scan.rb on lines 88..95
              lib/msf/core/db_manager/import/retina.rb on lines 87..94
              lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 28.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status