rapid7/metasploit-framework

View on GitHub
lib/msf/core/db_manager/import/nmap.rb

Summary

Maintainability
D
2 days
Test Coverage

Method import_nmap_xml has a Cognitive Complexity of 99 (exceeds 5 allowed). Consider refactoring.
Open

  def import_nmap_xml(args={}, &block)
    return nil if args[:data].nil? or args[:data].empty?
    wspace = Msf::Util::DBManager.process_opts_workspace(args, framework)
    bl = validate_ips(args[:blacklist]) ? args[:blacklist].split : []

Severity: Minor
Found in lib/msf/core/db_manager/import/nmap.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import_nmap_xml has 188 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def import_nmap_xml(args={}, &block)
    return nil if args[:data].nil? or args[:data].empty?
    wspace = Msf::Util::DBManager.process_opts_workspace(args, framework)
    bl = validate_ips(args[:blacklist]) ? args[:blacklist].split : []

Severity: Major
Found in lib/msf/core/db_manager/import/nmap.rb - About 7 hrs to fix

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

      def import_nmap_xml_file(args={})
        filename = args[:filename]
    
        data = ""
        ::File.open(filename, 'rb') do |f|
    Severity: Major
    Found in lib/msf/core/db_manager/import/nmap.rb and 10 other locations - About 20 mins to fix
    lib/msf/core/db_manager/import/ip360/v3.rb on lines 6..13
    lib/msf/core/db_manager/import/ip_list.rb on lines 18..25
    lib/msf/core/db_manager/import/metasploit_framework/xml.rb on lines 57..64
    lib/msf/core/db_manager/import/nessus/nbe.rb on lines 84..91
    lib/msf/core/db_manager/import/netsparker.rb on lines 161..168
    lib/msf/core/db_manager/import/nexpose/raw.rb on lines 74..81
    lib/msf/core/db_manager/import/nexpose/simple.rb on lines 155..162
    lib/msf/core/db_manager/import/qualys/scan.rb on lines 88..95
    lib/msf/core/db_manager/import/retina.rb on lines 87..94
    lib/msf/core/db_manager/import/wapiti.rb on lines 13..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 28.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status