Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/exploit/remote/smb/client.rb

Summary

Maintainability
F
5 days
Test Coverage

File client.rb has 637 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rex/encoder/ndr'
require 'recog'

module Msf
  module Exploit::Remote::SMB
Severity: Major
Found in lib/msf/core/exploit/remote/smb/client.rb - About 1 day to fix

    Method smb_fingerprint_windows_lang has 134 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def smb_fingerprint_windows_lang

        #
        # Remote language detection via Print Providers
        # Credit: http://immunityinc.com/downloads/Remote_Language_Detection_in_Immunity_CANVAS.odt
    Severity: Major
    Found in lib/msf/core/exploit/remote/smb/client.rb - About 5 hrs to fix

      Method smb_fingerprint_windows_lang has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

            def smb_fingerprint_windows_lang

        #
        # Remote language detection via Print Providers
        # Credit: http://immunityinc.com/downloads/Remote_Language_Detection_in_Immunity_CANVAS.odt
      Severity: Minor
      Found in lib/msf/core/exploit/remote/smb/client.rb - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method smb_fingerprint_windows_sp has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
      Open

            def smb_fingerprint_windows_sp(os)
        sp = ''

        if (os == 'Windows XP')
          # SRVSVC was blocked in SP2
      Severity: Minor
      Found in lib/msf/core/exploit/remote/smb/client.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method smb_fingerprint_windows_sp has 67 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def smb_fingerprint_windows_sp(os)
        sp = ''

        if (os == 'Windows XP')
          # SRVSVC was blocked in SP2
      Severity: Major
      Found in lib/msf/core/exploit/remote/smb/client.rb - About 2 hrs to fix

        Method smb_srvsvc_netshareenumall has 57 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def smb_srvsvc_netshareenumall
        shares = []
        simple.connect("\\\\#{rhost}\\IPC$")
        handle = dcerpc_handle('4b324fc8-1670-01d3-1278-5a47bf6ee188', '3.0', 'ncacn_np', ["\\srvsvc"])
        begin
        Severity: Major
        Found in lib/msf/core/exploit/remote/smb/client.rb - About 2 hrs to fix

          Method initialize has 50 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def initialize(info = {})
        super

        register_evasion_options(
        [
          Severity: Minor
          Found in lib/msf/core/exploit/remote/smb/client.rb - About 2 hrs to fix

            Method smb_srvsvc_netshareenumall has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                  def smb_srvsvc_netshareenumall
        shares = []
        simple.connect("\\\\#{rhost}\\IPC$")
        handle = dcerpc_handle('4b324fc8-1670-01d3-1278-5a47bf6ee188', '3.0', 'ncacn_np', ["\\srvsvc"])
        begin
            Severity: Minor
            Found in lib/msf/core/exploit/remote/smb/client.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method connect has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
            Open

                  def connect(global=true, versions: [], backend: nil)
        if versions.nil? || versions.empty?
          versions = datastore['SMB::ProtocolVersion'].split(',').map(&:strip).reject(&:blank?).map(&:to_i)
          # if the user explicitly set the protocol version to 1, still use ruby_smb
          backend ||= :ruby_smb if versions == [1]
            Severity: Minor
            Found in lib/msf/core/exploit/remote/smb/client.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method smb_login has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

                  def smb_login(simple_client = self.simple)
        # Override the default RubySMB capabilities with Kerberos authentication
        if datastore['SMB::Auth'] == Msf::Exploit::Remote::AuthOption::KERBEROS
          fail_with(Msf::Exploit::Failure::BadConfig, 'The Smb::Rhostname option is required when using Kerberos authentication.') if datastore['Smb::Rhostname'].blank?
          fail_with(Msf::Exploit::Failure::BadConfig, 'The SMBDomain option is required when using Kerberos authentication.') if datastore['SMBDomain'].blank?
            Severity: Minor
            Found in lib/msf/core/exploit/remote/smb/client.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method smb_srvsvc_netsharegetinfo has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def smb_srvsvc_netsharegetinfo(share)
        shares = []
        simple.connect("\\\\#{rhost}\\IPC$")
        handle = dcerpc_handle('4b324fc8-1670-01d3-1278-5a47bf6ee188', '3.0', 'ncacn_np', ["\\srvsvc"])
        begin
            Severity: Minor
            Found in lib/msf/core/exploit/remote/smb/client.rb - About 1 hr to fix

              Method smb_login has 37 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def smb_login(simple_client = self.simple)
        # Override the default RubySMB capabilities with Kerberos authentication
        if datastore['SMB::Auth'] == Msf::Exploit::Remote::AuthOption::KERBEROS
          fail_with(Msf::Exploit::Failure::BadConfig, 'The Smb::Rhostname option is required when using Kerberos authentication.') if datastore['Smb::Rhostname'].blank?
          fail_with(Msf::Exploit::Failure::BadConfig, 'The SMBDomain option is required when using Kerberos authentication.') if datastore['SMBDomain'].blank?
              Severity: Minor
              Found in lib/msf/core/exploit/remote/smb/client.rb - About 1 hr to fix

                Method smb_lanman_netshareenumall has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def smb_lanman_netshareenumall
        shares = []
        begin
          # XXX: #trans is not supported by RubySMB
          res = self.simple.client.trans(
                Severity: Minor
                Found in lib/msf/core/exploit/remote/smb/client.rb - About 1 hr to fix

                  Method smb_fingerprint has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        def smb_fingerprint
        fprint = {}

        # Connect to the server if needed
        if not self.simple
                  Severity: Minor
                  Found in lib/msf/core/exploit/remote/smb/client.rb - About 1 hr to fix

                    Method smb_fingerprint has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def smb_fingerprint
        fprint = {}

        # Connect to the server if needed
        if not self.simple
                    Severity: Minor
                    Found in lib/msf/core/exploit/remote/smb/client.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                            return resp
                    Severity: Major
                    Found in lib/msf/core/exploit/remote/smb/client.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return nil if pcnt < 3
                      Severity: Major
                      Found in lib/msf/core/exploit/remote/smb/client.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return nil if bcnt > blen
                        Severity: Major
                        Found in lib/msf/core/exploit/remote/smb/client.rb - About 30 mins to fix

                          Method smb_enumprintproviders has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def smb_enumprintproviders
        resp = smb_enumprinters(8, nil, 1, 0)
        return nil if not resp
        rptr, tmp, blen = resp.unpack("V*")
                          Severity: Minor
                          Found in lib/msf/core/exploit/remote/smb/client.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Method smb_srvsvc_netsharegetinfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def smb_srvsvc_netsharegetinfo(share)
        shares = []
        simple.connect("\\\\#{rhost}\\IPC$")
        handle = dcerpc_handle('4b324fc8-1670-01d3-1278-5a47bf6ee188', '3.0', 'ncacn_np', ["\\srvsvc"])
        begin
                          Severity: Minor
                          Found in lib/msf/core/exploit/remote/smb/client.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  lerror, lconv, lentries, lcount = res['Payload'].to_s[
          res['Payload'].v['ParamOffset'],
          res['Payload'].v['ParamCount']
        ].unpack("v4")
                          Severity: Minor
                          Found in lib/msf/core/exploit/remote/smb/client.rb and 1 other location - About 15 mins to fix
                          modules/exploits/windows/smb/ms10_061_spoolss.rb on lines 101..106

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 26.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status