Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/msf/core/payload/linux.rb

Summary

Maintainability
F
3 days
Test Coverage

Method apply_prepends has 267 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def apply_prepends(buf)
    pre = ''
    app = ''

    test_arch = [ *(self.arch) ]
Severity: Major
Found in lib/msf/core/payload/linux.rb - About 1 day to fix

    Method apply_prepends has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
    Open

      def apply_prepends(buf)
    pre = ''
    app = ''

    test_arch = [ *(self.arch) ]
    Severity: Minor
    Found in lib/msf/core/payload/linux.rb - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File linux.rb has 341 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Msf::Payload::Linux

  #
  # This mixin is chained within payloads that target the Linux platform.
  # It provides special prepends, to support things like chroot and setuid.
    Severity: Minor
    Found in lib/msf/core/payload/linux.rb - About 4 hrs to fix

      Method initialize has 68 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(info = {})
    ret = super(info)

    register_advanced_options(
      [
      Severity: Major
      Found in lib/msf/core/payload/linux.rb - About 2 hrs to fix

        Avoid deeply nested control flow statements.
        Open

              if (datastore['PrependSetresuid'])
        # setresuid(ruid=0, euid=0, suid=0)
        pre << "\x00\x00\x20\xe0"     #    eor r0, r0, r0                    #
        pre << "\x01\x10\x21\xe0"     #    eor r1, r1, r1                    #
        pre << "\x02\x20\x22\xe0"     #    eor r2, r2, r2                    #
        Severity: Major
        Found in lib/msf/core/payload/linux.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                if (datastore['PrependSetuid'])
        # setuid(0)
        pre << "\x00\x00\x20\xe0"     #    eor r0, r0, r0                    #
        pre << "\x17\x70\xa0\xe3"     #    mov r7, #23                       #
        pre << "\x00\x00\x00\xef"     #    svc                               #
          Severity: Major
          Found in lib/msf/core/payload/linux.rb - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    pre << "\x6a\x02"             + #   pushb   $0x2                       #
               "\x58"                 + #   popl    %eax                       #
               "\xcd\x80"             + #   int     $0x80       ; fork         #
               "\x85\xc0"             + #   test    %eax,%eax                  #
               "\x74\x06"             + #   jz      loc_000f                   #
            Severity: Minor
            Found in lib/msf/core/payload/linux.rb and 1 other location - About 25 mins to fix
            lib/rex/post/meterpreter/extensions/peinjector/peinjector.rb on lines 225..245

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 31.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status