Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb

Summary

Maintainability
F
6 days
Test Coverage

Method cmd_portfwd has a Cognitive Complexity of 85 (exceeds 5 allowed). Consider refactoring.
Open

  def cmd_portfwd(*args)
    args.unshift('list') if args.empty?

    # For clarity's sake.
    lport = nil
Severity: Minor
Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File net.rb has 510 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rex/post/meterpreter'
require 'rex/post/meterpreter/extensions/stdapi/command_ids'

module Rex
module Post
Severity: Major
Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 1 day to fix

    Method cmd_portfwd has 162 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def cmd_portfwd(*args)
    args.unshift('list') if args.empty?

    # For clarity's sake.
    lport = nil
    Severity: Major
    Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 6 hrs to fix

      Method cmd_route has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

        def cmd_route(*args)
    # Default to list
    if (args.length == 0)
      args.unshift('list')
    end
      Severity: Minor
      Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method cmd_route has 87 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def cmd_route(*args)
    # Default to list
    if (args.length == 0)
      args.unshift('list')
    end
      Severity: Major
      Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 3 hrs to fix

        Method cmd_netstat has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def cmd_netstat(*args)
    if args.include?('-h')
      @@netstat_opts.usage
      return 0
    end
        Severity: Minor
        Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 1 hr to fix

          Method cmd_resolve has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def cmd_resolve(*args)
    args.unshift('-h') if args.length == 0

    hostnames = []
    family = AF_INET
          Severity: Minor
          Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 1 hr to fix

            Method cmd_arp has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def cmd_arp(*args)
    if args.include?('-h')
      @@arp_opts.usage
      return 0
    end
            Severity: Minor
            Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 1 hr to fix

              Method cmd_resolve has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def cmd_resolve(*args)
    args.unshift('-h') if args.length == 0

    hostnames = []
    family = AF_INET
              Severity: Minor
              Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method cmd_netstat has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def cmd_netstat(*args)
    if args.include?('-h')
      @@netstat_opts.usage
      return 0
    end
              Severity: Minor
              Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method cmd_arp has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def cmd_arp(*args)
    if args.include?('-h')
      @@arp_opts.usage
      return 0
    end
              Severity: Minor
              Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                        return false
              Severity: Major
              Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                          return false
                Severity: Major
                Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return
                  Severity: Major
                  Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                              return false
                    Severity: Major
                    Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return
                      Severity: Major
                      Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb - About 30 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              when 'add'
        # Satisfy check to see that formatting is correct
        unless Rex::Socket.is_ip_addr?(args[0])
          print_error "Invalid subnet: #{args[0]}"
          return false
                        Severity: Major
                        Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb and 1 other location - About 1 hr to fix
                        lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb on lines 331..350

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 73.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              when 'delete'
        # Satisfy check to see that formatting is correct
        unless Rex::Socket.is_ip_addr?(args[0])
          print_error "Invalid subnet: #{args[0]}"
          return false
                        Severity: Major
                        Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb and 1 other location - About 1 hr to fix
                        lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb on lines 311..330

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 73.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                          @@portfwd_opts = Rex::Parser::Arguments.new(
    '-h' => [false, 'Help banner.'],
    '-i' => [true,  'Index of the port forward entry to interact with (see the "list" command).'],
    '-l' => [true,  'Forward: local port to listen on. Reverse: local port to connect to.'],
    '-r' => [true,  'Forward: remote host to connect to.'],
                        Severity: Minor
                        Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb and 1 other location - About 30 mins to fix
                        scripts/meterpreter/file_collector.rb on lines 17..25

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 33.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                routes.select {|route|
          Rex::Socket.is_ipv6?(route.netmask)
        }.each { |route|
          tbl << [ route.subnet, route.netmask, route.gateway, route.metric, route.interface ]
                        Severity: Minor
                        Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb and 1 other location - About 15 mins to fix
                        lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb on lines 275..278

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 25.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                routes.select {|route|
          Rex::Socket.is_ipv4?(route.netmask)
        }.each { |route|
          tbl << [ route.subnet, route.netmask, route.gateway, route.metric, route.interface ]
                        Severity: Minor
                        Found in lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb and 1 other location - About 15 mins to fix
                        lib/rex/post/meterpreter/ui/console/command_dispatcher/stdapi/net.rb on lines 299..302

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 25.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status