rapid7/metasploit-framework

View on GitHub
modules/auxiliary/admin/mssql/mssql_findandsampledata.rb

Summary

Maintainability
D
2 days
Test Coverage

Method sql_statement has 335 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def sql_statement()

    # DEFINED HEADER TEXT
    headings = [
      ["Server","Database", "Schema", "Table", "Column", "Data Type", "Sample Data","Row Count"]
Severity: Major
Found in modules/auxiliary/admin/mssql/mssql_findandsampledata.rb - About 1 day to fix

    File mssql_findandsampledata.rb has 376 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Auxiliary
      include Msf::Exploit::Remote::MSSQL
      include Msf::Auxiliary::Scanner
      include Msf::Auxiliary::Report
    
    
    Severity: Minor
    Found in modules/auxiliary/admin/mssql/mssql_findandsampledata.rb - About 5 hrs to fix

      Method sql_statement has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def sql_statement()
      
          # DEFINED HEADER TEXT
          headings = [
            ["Server","Database", "Schema", "Table", "Column", "Data Type", "Sample Data","Row Count"]
      Severity: Minor
      Found in modules/auxiliary/admin/mssql/mssql_findandsampledata.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (save_loot=="yes")
            filename= "#{datastore['RHOST']}-#{datastore['RPORT']}_sqlserver_query_results.csv"
            path = store_loot("mssql.data", "text/plain", datastore['RHOST'], sql_data_tbl.to_csv, filename, "SQL Server query results",this_service)
            print_good("Query results have been saved to: #{path}")
      Severity: Minor
      Found in modules/auxiliary/admin/mssql/mssql_findandsampledata.rb and 1 other location - About 30 mins to fix
      modules/exploits/windows/mssql/mssql_linkcrawler.rb on lines 257..260

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 33.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            sql_data_tbl << [row[0], row[1], row[2], row[3], row[4], row[5], row[6], row[7]]
      Severity: Minor
      Found in modules/auxiliary/admin/mssql/mssql_findandsampledata.rb and 2 other locations - About 20 mins to fix
      modules/post/multi/gather/dbvis_enum.rb on lines 213..213
      modules/post/multi/gather/thunderbird_creds.rb on lines 199..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            0.upto(7) { |col|
              buffer1 += row[col].ljust(widths[col] + 1)
              buffer2 += row[col] + ","
            }
      Severity: Minor
      Found in modules/auxiliary/admin/mssql/mssql_findandsampledata.rb and 1 other location - About 15 mins to fix
      modules/auxiliary/admin/mssql/mssql_findandsampledata.rb on lines 396..399

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            0.upto(7) { |col|
              buffer1 += row[col].ljust(widths[col] + 1)
              buffer2 += row[col]+ ","
            }
      Severity: Minor
      Found in modules/auxiliary/admin/mssql/mssql_findandsampledata.rb and 1 other location - About 15 mins to fix
      modules/auxiliary/admin/mssql/mssql_findandsampledata.rb on lines 420..423

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status