rapid7/metasploit-framework

View on GitHub
modules/auxiliary/analyze/crack_databases.rb

Summary

Maintainability
F
5 days
Test Coverage

Method check_results has a Cognitive Complexity of 97 (exceeds 5 allowed). Consider refactoring.
Open

    def check_results(passwords, results, hash_type, hashes, method, cracker)
      passwords.each do |password_line|
        password_line.chomp!
        next if password_line.blank?
        fields = password_line.split(":")
Severity: Minor
Found in modules/auxiliary/analyze/crack_databases.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 189 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    def process_crack(results, hashes, cred, hash_type, method)
      return results if cred['core_id'].nil? # make sure we have good data
      # make sure we dont add the same one again
      if results.select {|r| r.first == cred['core_id']}.empty?
Severity: Major
Found in modules/auxiliary/analyze/crack_databases.rb - About 7 hrs to fix

    Method run has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
        def process_crack(results, hashes, cred, hash_type, method)
          return results if cred['core_id'].nil? # make sure we have good data
          # make sure we dont add the same one again
          if results.select {|r| r.first == cred['core_id']}.empty?
    Severity: Minor
    Found in modules/auxiliary/analyze/crack_databases.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method hash_file has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

      def hash_file(hashes_regex)
        hashes = []
        wrote_hash = false
        hashlist = Rex::Quickfile.new("hashes_tmp")
        # Convert names from JtR to db
    Severity: Minor
    Found in modules/auxiliary/analyze/crack_databases.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File crack_databases.rb has 294 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class MetasploitModule < Msf::Auxiliary
      include Msf::Auxiliary::PasswordCracker
      include Msf::Exploit::Deprecated
      moved_from 'auxiliary/analyze/jtr_mssql_fast'
      moved_from 'auxiliary/analyze/jtr_mysql_fast'
    Severity: Minor
    Found in modules/auxiliary/analyze/crack_databases.rb - About 3 hrs to fix

      Method hash_file has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def hash_file(hashes_regex)
          hashes = []
          wrote_hash = false
          hashlist = Rex::Quickfile.new("hashes_tmp")
          # Convert names from JtR to db
      Severity: Minor
      Found in modules/auxiliary/analyze/crack_databases.rb - About 1 hr to fix

        Method initialize has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def initialize
            super(
              'Name'            => 'Password Cracker: Databases',
              'Description'     => %Q{
                  This module uses John the Ripper or Hashcat to identify weak passwords that have been
        Severity: Minor
        Found in modules/auxiliary/analyze/crack_databases.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def initialize
              super(
                'Name'            => 'Password Cracker: Databases',
                'Description'     => %Q{
                    This module uses John the Ripper or Hashcat to identify weak passwords that have been
          Severity: Major
          Found in modules/auxiliary/analyze/crack_databases.rb and 1 other location - About 1 hr to fix
          modules/auxiliary/analyze/crack_windows.rb on lines 12..44

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 6 locations. Consider refactoring.
          Open

              def process_crack(results, hashes, cred, hash_type, method)
                return results if cred['core_id'].nil? # make sure we have good data
                # make sure we dont add the same one again
                if results.select {|r| r.first == cred['core_id']}.empty?
                  results << [cred['core_id'], hash_type, cred['username'], cred['password'], method]
          Severity: Major
          Found in modules/auxiliary/analyze/crack_databases.rb and 5 other locations - About 1 hr to fix
          modules/auxiliary/analyze/crack_aix.rb on lines 65..73
          modules/auxiliary/analyze/crack_linux.rb on lines 71..79
          modules/auxiliary/analyze/crack_mobile.rb on lines 63..71
          modules/auxiliary/analyze/crack_osx.rb on lines 63..71
          modules/auxiliary/analyze/crack_webapps.rb on lines 65..73

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 7 locations. Consider refactoring.
          Open

            def show_command(cracker_instance)
              return unless datastore['ShowCommand']
              if action.name == 'john'
                cmd = cracker_instance.john_crack_command
              elsif action.name == 'hashcat'
          Severity: Major
          Found in modules/auxiliary/analyze/crack_databases.rb and 6 other locations - About 25 mins to fix
          modules/auxiliary/analyze/crack_aix.rb on lines 45..52
          modules/auxiliary/analyze/crack_linux.rb on lines 51..58
          modules/auxiliary/analyze/crack_mobile.rb on lines 43..50
          modules/auxiliary/analyze/crack_osx.rb on lines 43..50
          modules/auxiliary/analyze/crack_webapps.rb on lines 45..52
          modules/auxiliary/analyze/crack_windows.rb on lines 55..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 29.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status