Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/apple_safari_ftp_url_cookie_theft.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method start_http has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def start_http(opts={})
    # Ensture all dependencies are present before initializing HTTP
    use_zlib

    comm = datastore['ListenerComm']
Severity: Minor
Found in modules/auxiliary/gather/apple_safari_ftp_url_cookie_theft.rb - About 1 hr to fix

    Method initialize has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info={})
    super(update_info(info,
      'Name'        => 'Apple OSX/iOS/Windows Safari Non-HTTPOnly Cookie Theft',
      'Description' => %q{
        A vulnerability exists in versions of OSX, iOS, and Windows Safari released
    Severity: Minor
    Found in modules/auxiliary/gather/apple_safari_ftp_url_cookie_theft.rb - About 1 hr to fix

      Method on_request_uri has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def on_request_uri(cli, request)
    if request.method.downcase == 'post'
      json = JSON.parse(request.body)
      domain = json['domain']
      cookie = Rex::Text.decode_base64(json['p']).to_s
      Severity: Minor
      Found in modules/auxiliary/gather/apple_safari_ftp_url_cookie_theft.rb - About 1 hr to fix

        Method start_http has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def start_http(opts={})
    # Ensture all dependencies are present before initializing HTTP
    use_zlib

    comm = datastore['ListenerComm']
        Severity: Minor
        Found in modules/auxiliary/gather/apple_safari_ftp_url_cookie_theft.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

          def send_response(cli, code, message='OK', html='')
    proto = Rex::Proto::Http::DefaultProtocol
    res = Rex::Proto::Http::Response.new(code, message, proto)
    res['Content-Type'] = 'text/html'
    res.body = html
        Severity: Minor
        Found in modules/auxiliary/gather/apple_safari_ftp_url_cookie_theft.rb and 3 other locations - About 25 mins to fix
        modules/auxiliary/gather/safari_file_url_navigation.rb on lines 299..305
        modules/exploits/multi/http/log4shell_header_injection.rb on lines 173..178
        modules/exploits/osx/browser/safari_file_policy.rb on lines 309..315

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status