Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/gather/snare_registry.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method dump_key has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def dump_key(reg_key)
    if reg_key.blank?
      fail_with(Failure::BadConfig, "#{peer} - Please supply a valid key name")
    end
    hive = reg_key.split('\\').first
Severity: Minor
Found in modules/auxiliary/gather/snare_registry.rb - About 1 hr to fix

    Method dump_key has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def dump_key(reg_key)
    if reg_key.blank?
      fail_with(Failure::BadConfig, "#{peer} - Please supply a valid key name")
    end
    hive = reg_key.split('\\').first
    Severity: Minor
    Found in modules/auxiliary/gather/snare_registry.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def initialize(info = {})
    super(update_info(info,
      'Name'          => 'Snare Lite for Windows Registry Access',
      'Description'   => %q{
          This module uses the Registry Dump feature of the Snare Lite
    Severity: Minor
    Found in modules/auxiliary/gather/snare_registry.rb - About 1 hr to fix

      Method retrieve_hive_list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def retrieve_hive_list
    hives = []
    print_status("#{peer} - Retrieving list of registry hives ...")
    res = send_request_cgi(
      'uri' => normalize_uri('RegDump'),
      Severity: Minor
      Found in modules/auxiliary/gather/snare_registry.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status