rapid7/metasploit-framework

View on GitHub
modules/auxiliary/gather/ssllabs_scan.rb

Summary

Maintainability
F
5 days
Test Coverage

File ssllabs_scan.rb has 732 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'active_support/inflector'
require 'json'
require 'active_support/core_ext/hash'

class MetasploitModule < Msf::Auxiliary
Severity: Major
Found in modules/auxiliary/gather/ssllabs_scan.rb - About 1 day to fix

    Method output_endpoint_data has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
    Open

      def output_endpoint_data(r)
        ssl_protocols = [
          { id: 771, name: "TLS", version: "1.2", secure: true, active: false },
          { id: 770, name: "TLS", version: "1.1", secure: true, active: false },
          { id: 769, name: "TLS", version: "1.0", secure: true, active: false },
    Severity: Minor
    Found in modules/auxiliary/gather/ssllabs_scan.rb - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method output_endpoint_data has 167 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def output_endpoint_data(r)
        ssl_protocols = [
          { id: 771, name: "TLS", version: "1.2", secure: true, active: false },
          { id: 770, name: "TLS", version: "1.1", secure: true, active: false },
          { id: 769, name: "TLS", version: "1.0", secure: true, active: false },
    Severity: Major
    Found in modules/auxiliary/gather/ssllabs_scan.rb - About 6 hrs to fix

      Method run has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
          delay = datastore['DELAY']
          hostname = datastore['HOSTNAME']
          unless valid_hostname?(hostname)
            print_status "Invalid hostname"
      Severity: Minor
      Found in modules/auxiliary/gather/ssllabs_scan.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
          delay = datastore['DELAY']
          hostname = datastore['HOSTNAME']
          unless valid_hostname?(hostname)
            print_status "Invalid hostname"
      Severity: Major
      Found in modules/auxiliary/gather/ssllabs_scan.rb - About 2 hrs to fix

        Method load has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.load(attributes = {})
              obj = self.new
              unused_attrs = []
              attributes.each do |name, value|
                if @fields.include?(name)
        Severity: Minor
        Found in modules/auxiliary/gather/ssllabs_scan.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method request has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def request(name, params = {})
              api_host = "api.ssllabs.com"
              api_port = "443"
              api_path = "/api/v2/"
              user_agent = "Msf_ssllabs_scan"
        Severity: Minor
        Found in modules/auxiliary/gather/ssllabs_scan.rb - About 1 hr to fix

          Method initialize has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def initialize(info = {})
              super(update_info(info,
                  'Name'          => 'SSL Labs API Client',
                  'Description'   => %q{
                    This module is a simple client for the SSL Labs APIs, designed for
          Severity: Minor
          Found in modules/auxiliary/gather/ssllabs_scan.rb - About 1 hr to fix

            Method output_result has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def output_result(r, grade)
                return unless r
                output_common_info(r)
                if grade
                  output_grades_only(r)
            Severity: Minor
            Found in modules/auxiliary/gather/ssllabs_scan.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method output_testing_details has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def output_testing_details(r)
                return unless r.status == "IN_PROGRESS"
            
                if r.endpoints.length == 1
                  print_status "#{r.host} (#{r.endpoints[0].ip_address}) - Progress #{[r.endpoints[0].progress, 0].max}% (#{r.endpoints[0].status_details_message})"
            Severity: Minor
            Found in modules/auxiliary/gather/ssllabs_scan.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                    return
            Severity: Major
            Found in modules/auxiliary/gather/ssllabs_scan.rb - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  case
                  when r.details.session_tickets == 0
                    print_status "Session tickets - No"
                  when r.details.session_tickets[0] == 1
                    print_status "Session tickets - Yes"
              Severity: Minor
              Found in modules/auxiliary/gather/ssllabs_scan.rb and 1 other location - About 50 mins to fix
              modules/auxiliary/gather/ssllabs_scan.rb on lines 648..656

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  case
                  when r.details.forward_secrecy == 0
                    report_bad "Forward Secrecy - No"
                  when r.details.forward_secrecy[0] == 1
                    report_bad "Forward Secrecy - With some browsers"
              Severity: Minor
              Found in modules/auxiliary/gather/ssllabs_scan.rb and 1 other location - About 50 mins to fix
              modules/auxiliary/gather/ssllabs_scan.rb on lines 696..704

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status