Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/jenkins_enum.rb

Summary

Maintainability
C
1 day
Test Coverage

Method parse_system_info has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_system_info(body)
    vprint_status("Getting useful information from systemInfo")
    infos = {
      "os.name"            => nil,
      "os.version"         => nil,
Severity: Major
Found in modules/auxiliary/scanner/http/jenkins_enum.rb - About 3 hrs to fix

    Method check_app has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def check_app(app)
    uri_path = normalize_uri(target_uri.path, app)
    res = send_request_cgi({
      'uri'       => uri_path,
      'method'    => 'GET',
    Severity: Minor
    Found in modules/auxiliary/scanner/http/jenkins_enum.rb - About 1 hr to fix

      Method run_host has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run_host(ip)
    res = send_request_cgi(
      {
      'uri'       => target_uri.path,
      'method'    => 'GET',
      Severity: Minor
      Found in modules/auxiliary/scanner/http/jenkins_enum.rb - About 1 hr to fix

        Method parse_system_info has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def parse_system_info(body)
    vprint_status("Getting useful information from systemInfo")
    infos = {
      "os.name"            => nil,
      "os.version"         => nil,
        Severity: Minor
        Found in modules/auxiliary/scanner/http/jenkins_enum.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_app has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def check_app(app)
    uri_path = normalize_uri(target_uri.path, app)
    res = send_request_cgi({
      'uri'       => uri_path,
      'method'    => 'GET',
        Severity: Minor
        Found in modules/auxiliary/scanner/http/jenkins_enum.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run_host has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def run_host(ip)
    res = send_request_cgi(
      {
      'uri'       => target_uri.path,
      'method'    => 'GET',
        Severity: Minor
        Found in modules/auxiliary/scanner/http/jenkins_enum.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status