Sign upLogin

rapid7/metasploit-framework

View on GitHub
Star
modules/auxiliary/scanner/http/joomla_bruteforce_login.rb

Summary

Maintainability
C
1 day
Test Coverage

Method find_auth_uri has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def find_auth_uri
    if datastore['AUTH_URI'] && datastore['AUTH_URI'].length > 0
      paths = [datastore['AUTH_URI']]
    else
      paths = %w(
Severity: Minor
Found in modules/auxiliary/scanner/http/joomla_bruteforce_login.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_web_login has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def do_web_login(user, pass)
    user_var = datastore['USER_VARIABLE']
    pass_var = datastore['PASS_VARIABLE']

    referer_var = "http://#{rhost}/administrator/index.php"
Severity: Minor
Found in modules/auxiliary/scanner/http/joomla_bruteforce_login.rb - About 1 hr to fix

    Method do_web_login has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def do_web_login(user, pass)
    user_var = datastore['USER_VARIABLE']
    pass_var = datastore['PASS_VARIABLE']

    referer_var = "http://#{rhost}/administrator/index.php"
    Severity: Minor
    Found in modules/auxiliary/scanner/http/joomla_bruteforce_login.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_auth_uri has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def find_auth_uri
    if datastore['AUTH_URI'] && datastore['AUTH_URI'].length > 0
      paths = [datastore['AUTH_URI']]
    else
      paths = %w(
    Severity: Minor
    Found in modules/auxiliary/scanner/http/joomla_bruteforce_login.rb - About 1 hr to fix

      Method determine_result has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def determine_result(response)
    return :abort unless response.kind_of?(Rex::Proto::Http::Response)
    return :abort unless response.code

    if [200, 301, 302].include?(response.code)
      Severity: Minor
      Found in modules/auxiliary/scanner/http/joomla_bruteforce_login.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

            return nil
      Severity: Major
      Found in modules/auxiliary/scanner/http/joomla_bruteforce_login.rb - About 30 mins to fix

        Method get_login_hidden has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def get_login_hidden(res)
    return nil unless res.kind_of?(Rex::Proto::Http::Response)

    return nil if res.body.blank?
        Severity: Minor
        Found in modules/auxiliary/scanner/http/joomla_bruteforce_login.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 8 locations. Consider refactoring.
        Open

          def report_cred(opts)
    service_data = {
      address: opts[:ip],
      port: opts[:port],
      service_name: (ssl ? 'https' : 'http'),
        Severity: Major
        Found in modules/auxiliary/scanner/http/joomla_bruteforce_login.rb and 7 other locations - About 1 hr to fix
        modules/auxiliary/scanner/http/axis_local_file_include.rb on lines 64..88
        modules/auxiliary/scanner/http/dlink_dir_300_615_http_login.rb on lines 81..105
        modules/auxiliary/scanner/http/dlink_dir_615h_http_login.rb on lines 111..135
        modules/auxiliary/scanner/http/dlink_dir_session_cgi_http_login.rb on lines 84..108
        modules/auxiliary/scanner/http/dolibarr_login.rb on lines 56..80
        modules/auxiliary/scanner/http/ektron_cms400net.rb on lines 126..150
        modules/auxiliary/scanner/http/etherpad_duo_login.rb on lines 68..92

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status